Testing #138

Closed
pascalduez opened this Issue Jul 25, 2014 · 12 comments

Comments

Projects
None yet
2 participants
@pascalduez
Member

pascalduez commented Jul 25, 2014

The idea is to write a set of Sass fixtures to be able to unit test against it.
Similar to this.

Expect following comment/case to produce this data object.
Something in this mood.

This is a following of #112.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Jul 26, 2014

Member

Can we close this?

Member

HugoGiraudel commented Jul 26, 2014

Can we close this?

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Jul 26, 2014

Member

Right now there is only a new test for the empty documentation case. All the other ones are still to write, and figure out.

Member

pascalduez commented Jul 26, 2014

Right now there is only a new test for the empty documentation case. All the other ones are still to write, and figure out.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Jul 26, 2014

Member

Feel like doing it or not particularly?

Member

HugoGiraudel commented Jul 26, 2014

Feel like doing it or not particularly?

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Jul 26, 2014

Member

Feel like. But need to figure out first what's the relevant way.
Also monitoring recent API changes, they might have a serious impact.

Member

pascalduez commented Jul 26, 2014

Feel like. But need to figure out first what's the relevant way.
Also monitoring recent API changes, they might have a serious impact.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Jul 26, 2014

Member

@pascalduez The empty test task is broken:

Running "compile:empty" (compile) task
[2014-07-26 23:08:53] Folder `develop/empty` successfully removed.
[2014-07-26 23:08:53] Folder `develop/empty` successfully generated.
[2014-07-26 23:08:53] [ERROR] Error: TypeError: path must be a string
    at /Users/administrateur/Documents/sassdoc/sassdoc/src/file.js:111:15
    at _rejected (/Users/administrateur/Documents/sassdoc/sassdoc/node_modules/q/q.js:797:24)
    at /Users/administrateur/Documents/sassdoc/sassdoc/node_modules/q/q.js:823:30
    at Promise.when (/Users/administrateur/Documents/sassdoc/sassdoc/node_modules/q/q.js:1035:31)
    at Promise.promise.promiseDispatch (/Users/administrateur/Documents/sassdoc/sassdoc/node_modules/q/q.js:741:41)
    at /Users/administrateur/Documents/sassdoc/sassdoc/node_modules/q/q.js:557:44
    at flush (/Users/administrateur/Documents/sassdoc/sassdoc/node_modules/q/q.js:108:17)
    at process._tickDomainCallback (node.js:459:13)
Member

HugoGiraudel commented Jul 26, 2014

@pascalduez The empty test task is broken:

Running "compile:empty" (compile) task
[2014-07-26 23:08:53] Folder `develop/empty` successfully removed.
[2014-07-26 23:08:53] Folder `develop/empty` successfully generated.
[2014-07-26 23:08:53] [ERROR] Error: TypeError: path must be a string
    at /Users/administrateur/Documents/sassdoc/sassdoc/src/file.js:111:15
    at _rejected (/Users/administrateur/Documents/sassdoc/sassdoc/node_modules/q/q.js:797:24)
    at /Users/administrateur/Documents/sassdoc/sassdoc/node_modules/q/q.js:823:30
    at Promise.when (/Users/administrateur/Documents/sassdoc/sassdoc/node_modules/q/q.js:1035:31)
    at Promise.promise.promiseDispatch (/Users/administrateur/Documents/sassdoc/sassdoc/node_modules/q/q.js:741:41)
    at /Users/administrateur/Documents/sassdoc/sassdoc/node_modules/q/q.js:557:44
    at flush (/Users/administrateur/Documents/sassdoc/sassdoc/node_modules/q/q.js:108:17)
    at process._tickDomainCallback (node.js:459:13)
@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Jul 26, 2014

Member

The empty test task is broken

Working here, must be related to latest changes.
Investigating.

Member

pascalduez commented Jul 26, 2014

The empty test task is broken

Working here, must be related to latest changes.
Investigating.

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Jul 26, 2014

Member

I get it. The task for testing the empty behavior is grunt empty not grunt compile:empty.
compile:empty is called internally by grunt empty.

Member

pascalduez commented Jul 26, 2014

I get it. The task for testing the empty behavior is grunt empty not grunt compile:empty.
compile:empty is called internally by grunt empty.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Jul 26, 2014

Member

It happens when running grunt compile. Is it expected?

Member

HugoGiraudel commented Jul 26, 2014

It happens when running grunt compile. Is it expected?

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Jul 26, 2014

Member

It happens when running grunt compile. Is it expected?

compile is now a MultiTask, so if run without a target, it will run all targets.
If in need of running it directly, then grunt compile:develop should be used.

But basically, grunt develop is the main task.

Member

pascalduez commented Jul 26, 2014

It happens when running grunt compile. Is it expected?

compile is now a MultiTask, so if run without a target, it will run all targets.
If in need of running it directly, then grunt compile:develop should be used.

But basically, grunt develop is the main task.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Jul 27, 2014

Member

Okay, thanks for the hint.

Member

HugoGiraudel commented Jul 27, 2014

Okay, thanks for the hint.

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Jul 27, 2014

Member

I'm currently simplifying this. Will post instructions.

Member

pascalduez commented Jul 27, 2014

I'm currently simplifying this. Will post instructions.

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Jul 28, 2014

Member

The data unit tests have been merged into develop. This is a first step, we will probably refine/tweak them later.

The grunt tasks have also been simplified.

$ grunt compile:develop compile theme scss
$ grunt compile:empty compile an empty folder
$ grunt compile run both the above

$ grunt develop still the main development task.
If not develop folder is present, it will create it (run an initial compile) now.

Member

pascalduez commented Jul 28, 2014

The data unit tests have been merged into develop. This is a first step, we will probably refine/tweak them later.

The grunt tasks have also been simplified.

$ grunt compile:develop compile theme scss
$ grunt compile:empty compile an empty folder
$ grunt compile run both the above

$ grunt develop still the main development task.
If not develop folder is present, it will create it (run an initial compile) now.

@pascalduez pascalduez closed this Jul 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment