Allow CLI options in the file #247

Closed
HugoGiraudel opened this Issue Oct 9, 2014 · 12 comments

Comments

Projects
None yet
3 participants
@HugoGiraudel
Member

HugoGiraudel commented Oct 9, 2014

What about allowing --sass-convert, --no-update-notifier and --no-prompt to live in the configuration file rather than passing those as CLI options?

Ideally, I think we should have a single option: --config. Everything else should live in the configuration file.

What do you think?

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat Oct 9, 2014

Member

Why not both?

Sometimes, you only want to tweak a configuration value for a single CLI call, and it's annoying to edit a file for this. BTW we have no way to configure everything with the CLI, but the above options are probably the more common for this "single call" use.

Member

valeriangalliat commented Oct 9, 2014

Why not both?

Sometimes, you only want to tweak a configuration value for a single CLI call, and it's annoying to edit a file for this. BTW we have no way to configure everything with the CLI, but the above options are probably the more common for this "single call" use.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Oct 9, 2014

Member

Then let's allow both.

Member

HugoGiraudel commented Oct 9, 2014

Then let's allow both.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Oct 9, 2014

Member

Who takes it?

Member

HugoGiraudel commented Oct 9, 2014

Who takes it?

@HugoGiraudel HugoGiraudel added this to the 1.10 milestone Oct 9, 2014

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Oct 9, 2014

Member

@FWeinb Your move. :)

Member

HugoGiraudel commented Oct 9, 2014

@FWeinb Your move. :)

@FWeinb

This comment has been minimized.

Show comment
Hide comment
@FWeinb

FWeinb Oct 10, 2014

Member

It is kinda hard to do that. The location of the config file can be specified by a command line option. So we have a chicken egg problem here.

Member

FWeinb commented Oct 10, 2014

It is kinda hard to do that. The location of the config file can be specified by a command line option. So we have a chicken egg problem here.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Oct 10, 2014

Member

I don't understand the issue.

Member

HugoGiraudel commented Oct 10, 2014

I don't understand the issue.

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat Oct 10, 2014

Member

I don't understand either.

Member

valeriangalliat commented Oct 10, 2014

I don't understand either.

@FWeinb

This comment has been minimized.

Show comment
Hide comment
@FWeinb

FWeinb Oct 10, 2014

Member

Maybe @valeriangalliat should take this. You wrote the config loading in the first place.

Member

FWeinb commented Oct 10, 2014

Maybe @valeriangalliat should take this. You wrote the config loading in the first place.

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat Oct 10, 2014

Member

No problem, I'll do it this week-end (and perhaps I'll ran in the same issue as you, but I don't see the chicken egg problem right now).

Member

valeriangalliat commented Oct 10, 2014

No problem, I'll do it this week-end (and perhaps I'll ran in the same issue as you, but I don't see the chicken egg problem right now).

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat Oct 10, 2014

Member

Naturally, the CLI options take precedence over the configuration ones.

Member

valeriangalliat commented Oct 10, 2014

Naturally, the CLI options take precedence over the configuration ones.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Nov 25, 2014

Member

@SassDoc/owners Please guys, make sure this is still possible with new API.

Member

HugoGiraudel commented Nov 25, 2014

@SassDoc/owners Please guys, make sure this is still possible with new API.

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat Nov 25, 2014

Member

All the CLI options have a corresponding configuration option. The list is here.

Member

valeriangalliat commented Nov 25, 2014

All the CLI options have a corresponding configuration option. The list is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment