Incorrect handling of `@return` #277

Closed
HugoGiraudel opened this Issue Nov 24, 2014 · 8 comments

Comments

Projects
None yet
3 participants
@HugoGiraudel
Member

HugoGiraudel commented Nov 24, 2014

I am not sure what we tried to do with the @return annotation here: https://github.com/SassDoc/sassdoc/blob/master/src/annotation/annotations/returns.js.

Anyway, a return statement has no name, nor default value. It has a type and a description, end of story. Documentation is correct here: http://sassdoc.com/annotations/#returns-synonym-return.

@HugoGiraudel HugoGiraudel added the Bug label Nov 24, 2014

@HugoGiraudel HugoGiraudel added this to the 2.0 milestone Nov 24, 2014

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Nov 24, 2014

Member

I don't there is much point fixing it in 1.*. Let's fix it in 2.0.

Member

HugoGiraudel commented Nov 24, 2014

I don't there is much point fixing it in 1.*. Let's fix it in 2.0.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Nov 24, 2014

Member

@FWeinb or @valeriangalliat, feel free to fix this one on develop.

Member

HugoGiraudel commented Nov 24, 2014

@FWeinb or @valeriangalliat, feel free to fix this one on develop.

@FWeinb

This comment has been minimized.

Show comment
Hide comment
@FWeinb

FWeinb Nov 24, 2014

Member

It was merged from refacto no need to do anything.

Member

FWeinb commented Nov 24, 2014

It was merged from refacto no need to do anything.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Nov 24, 2014

Member

I still see name and default here.

Member

HugoGiraudel commented Nov 24, 2014

I still see name and default here.

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat Nov 24, 2014

Member

The tests are wrong too. I'm fixing this.

Member

valeriangalliat commented Nov 24, 2014

The tests are wrong too. I'm fixing this.

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment