Destination folder relative to config file #403

Closed
pascalduez opened this Issue May 25, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@pascalduez
Member

pascalduez commented May 25, 2015

sassdoc foo/
--> creates a sassdoc folder in current working dir.

sassdoc foo/ -c bar/config.json
--> creates a sassdoc folder in bar/.

@valeriangalliat is that intended somehow ? I find it a bit confusing, plus it's breaking the grunt-sassdoc tests, which makes me think it's been introduced by a recent refactor.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel May 25, 2015

Member

That seems confusing to me.

Member

HugoGiraudel commented May 25, 2015

That seems confusing to me.

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat May 26, 2015

Member

Oh so this was not a bug in grunt-sassdoc tests. Nope this is not intended.

The bug was introduced with c47dea1. The idea was to make dest relative to the configuration file only when defined from the configuration file. When dest is explicitely given via CLI argument, it is effectively relative to the CWD. The problem is when using the default dest.

I'm looking how to fix this.

Member

valeriangalliat commented May 26, 2015

Oh so this was not a bug in grunt-sassdoc tests. Nope this is not intended.

The bug was introduced with c47dea1. The idea was to make dest relative to the configuration file only when defined from the configuration file. When dest is explicitely given via CLI argument, it is effectively relative to the CWD. The problem is when using the default dest.

I'm looking how to fix this.

@valeriangalliat valeriangalliat self-assigned this May 26, 2015

@valeriangalliat valeriangalliat added the Bug label May 26, 2015

valeriangalliat added a commit that referenced this issue May 26, 2015

Add a test case for relative destination
The destination should be relative to configuration file only when set
from configuration file.

Refs: #403

valeriangalliat added a commit that referenced this issue May 26, 2015

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat May 26, 2015

Member

@pascalduez In grunt-sassdoc, if dest was supposed to be relative to CWD, why was test/docs ignored in .gitignore (instead of docs)?

Member

valeriangalliat commented May 26, 2015

@pascalduez In grunt-sassdoc, if dest was supposed to be relative to CWD, why was test/docs ignored in .gitignore (instead of docs)?

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez May 26, 2015

Member

@valeriangalliat In grunt-sassdoc tests I don't use the dest option so I assumed all tests to use the CWD (root of the project). In fact, there's only one breaking, the one with a config file.

Member

pascalduez commented May 26, 2015

@valeriangalliat In grunt-sassdoc tests I don't use the dest option so I assumed all tests to use the CWD (root of the project). In fact, there's only one breaking, the one with a config file.

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez May 26, 2015

Member

why was test/docs ignored in .gitignore (instead of docs) ?

Well well, I don't remember, that's probably wrong ;-)

Member

pascalduez commented May 26, 2015

why was test/docs ignored in .gitignore (instead of docs) ?

Well well, I don't remember, that's probably wrong ;-)

valeriangalliat added a commit that referenced this issue May 26, 2015

Add a test case for relative destination
The destination should be relative to configuration file only when set
from configuration file.

Refs: #403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment