New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling sassdoc({verbose: true}) causes error #490

Closed
timcosgrove opened this Issue Mar 24, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@timcosgrove

timcosgrove commented Mar 24, 2017

#489 changes the behavior of verbose. Unfortunately this seems to run afoul of reserved key checks.

sassdoc.ensureEnvironment() instantiates the env (checking for config.verbose) and then invokes env.load(config)

Given the case where config is a plain object, env.load() invokes env.loadObject():

if (is.plainObject(config)) {

env.loadObject() checks for reserved configuration keys:

for (let k of Object.keys(config)) {

verbose was added as a key in #489:

this.verbose = verbose

Given all this, it seems like there would be no way to call sassdoc(configObject) where the configObject has a key of verbose, despite sassdoc making use of the verbose key elsewhere.

Will create a basic POC gist.

@pascalduez

This comment has been minimized.

Member

pascalduez commented Mar 24, 2017

Thanks for reporting, we will try to fix this ASAP. In the meantime you could downgrade to 2.2.0.

@timcosgrove

This comment has been minimized.

timcosgrove commented Mar 24, 2017

Appreciate the attention!

We'll shrinkwrap if we have to. Thank you~!

@pascalduez

This comment has been minimized.

Member

pascalduez commented Mar 27, 2017

Should be fixed as of sassdoc@2.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment