Proper behavior when the default theme is missing #207

Merged
merged 5 commits into from Sep 20, 2014

Conversation

Projects
None yet
3 participants
@valeriangalliat
Member

valeriangalliat commented Sep 16, 2014

Throw an Error instance so it's not ignored in the promises flow, and allow to pass the --theme option to cfg function so there's no need for two passes to resolve the theme.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Sep 20, 2014

Member

Can we merge this or?

Member

HugoGiraudel commented Sep 20, 2014

Can we merge this or?

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Sep 20, 2014

Member

Would be better to have @valeriangalliat confirmation, but I think it's clean, we've been discussing it extensively, and I also tested it myself.

Member

pascalduez commented Sep 20, 2014

Would be better to have @valeriangalliat confirmation, but I think it's clean, we've been discussing it extensively, and I also tested it myself.

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat Sep 20, 2014

Member

Everything is okay, you can merge. :)

Member

valeriangalliat commented Sep 20, 2014

Everything is okay, you can merge. :)

@valeriangalliat valeriangalliat merged commit c4315a8 into develop Sep 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@valeriangalliat valeriangalliat deleted the missing-default-theme branch Sep 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment