[RFR] Autofill access based on privatePrefix #357

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants
@FWeinb
Member

FWeinb commented Feb 4, 2015

See #340

@FWeinb FWeinb referenced this pull request Feb 4, 2015

Closed

Infer @access based on name #340

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Feb 4, 2015

Member

I'd rather see typeof env.privatePrefix !== 'undefined'.

I'd rather see typeof env.privatePrefix !== 'undefined'.

@FWeinb FWeinb added the Feature label Feb 4, 2015

@FWeinb FWeinb added this to the 2.1 milestone Feb 4, 2015

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 4, 2015

Coverage Status

Coverage increased (+0.05%) to 94.08% when pulling 233bd12 on autofill-access into e12c691 on develop.

Coverage Status

Coverage increased (+0.05%) to 94.08% when pulling 233bd12 on autofill-access into e12c691 on develop.

src/annotation/annotations/access.js
@@ -6,6 +9,21 @@ export default function access() {
return text.trim();
},
+ autofill(item) {
+ if (env.privatePrefix === false) { return; }

This comment has been minimized.

@HugoGiraudel

HugoGiraudel Feb 5, 2015

Member

Missing linebreaks here.

@HugoGiraudel

HugoGiraudel Feb 5, 2015

Member

Missing linebreaks here.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Feb 5, 2015

Member

Looks alright to me. We should not forget to PR the docs.

Member

HugoGiraudel commented Feb 5, 2015

Looks alright to me. We should not forget to PR the docs.

@HugoGiraudel HugoGiraudel referenced this pull request in SassDoc/sassdoc.github.io Feb 5, 2015

Merged

[RFR] Added docs for privatePrefix option #110

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment

@HugoGiraudel HugoGiraudel changed the title from Autofill access based on privatePrefix to [RFR] Autofill access based on privatePrefix Feb 7, 2015

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Feb 7, 2015

Member

LGTM. 👍

Member

HugoGiraudel commented Feb 7, 2015

LGTM. 👍

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Feb 7, 2015

Member

@FWeinb Whenever you feel like it.

Member

HugoGiraudel commented Feb 7, 2015

@FWeinb Whenever you feel like it.

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Feb 8, 2015

Member

Manually merged.

Member

pascalduez commented Feb 8, 2015

Manually merged.

@pascalduez pascalduez closed this Feb 8, 2015

@pascalduez pascalduez deleted the autofill-access branch Feb 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment