[RFR] Add @​name annotation #358

Merged
merged 2 commits into from Feb 8, 2015

Conversation

Projects
None yet
4 participants
@FWeinb
Member

FWeinb commented Feb 4, 2015

See #296

@FWeinb FWeinb added the Feature label Feb 4, 2015

@FWeinb FWeinb added this to the 2.1 milestone Feb 4, 2015

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 4, 2015

Coverage Status

Coverage increased (+0.05%) to 94.07% when pulling 0dda650 on name-annotation-v2 into 30bb313 on develop.

Coverage Status

Coverage increased (+0.05%) to 94.07% when pulling 0dda650 on name-annotation-v2 into 30bb313 on develop.

src/annotation/annotations/name.js
+ },
+
+ // Abuse the autofill feature to rewrite the `item.context`
+ autofill(item){

This comment has been minimized.

@HugoGiraudel

HugoGiraudel Feb 5, 2015

Member

Missing space before brace.

@HugoGiraudel

HugoGiraudel Feb 5, 2015

Member

Missing space before brace.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Feb 5, 2015

Member

It looks fine to me. We should not forget to PR the docs.

Member

HugoGiraudel commented Feb 5, 2015

It looks fine to me. We should not forget to PR the docs.

@HugoGiraudel HugoGiraudel referenced this pull request in SassDoc/sassdoc.github.io Feb 5, 2015

Merged

[RFR] Added docs for name annotation #109

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment

@HugoGiraudel HugoGiraudel changed the title from Add @​name annotation to [RFR] Add @​name annotation Feb 7, 2015

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Feb 7, 2015

Member

LGTM. 👍

Member

HugoGiraudel commented Feb 7, 2015

LGTM. 👍

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Feb 7, 2015

Member

@FWeinb Whenever you feel like it.

Member

HugoGiraudel commented Feb 7, 2015

@FWeinb Whenever you feel like it.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 8, 2015

Coverage Status

Coverage increased (+0.28%) to 94.31% when pulling c25879b on name-annotation-v2 into 30bb313 on develop.

Coverage Status

Coverage increased (+0.28%) to 94.31% when pulling c25879b on name-annotation-v2 into 30bb313 on develop.

pascalduez added a commit that referenced this pull request Feb 8, 2015

@pascalduez pascalduez merged commit 341adad into develop Feb 8, 2015

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.28%) to 94.31%
Details

@pascalduez pascalduez deleted the name-annotation-v2 branch Feb 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment