New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope empty data warning under the verbose flag #489

Merged
merged 2 commits into from Mar 23, 2017

Conversation

Projects
None yet
3 participants
@pascalduez
Member

pascalduez commented Mar 21, 2017

See #488

I tried to only scope that warning, so that we don't drastically change all the other behaviours (annotation warnings etc.).

Also removed the CSS selector sentence from the warning since this is no longer true, although we don't do much promotion around it.

pascalduez added some commits Mar 21, 2017

Remove empty data warning about CSS selectors
- This is no longer true, although not promoted.
Scope empty data message under the verbose flag
- This prevent unwanted logs for special configurations
- See #488
@coveralls

This comment has been minimized.

coveralls commented Mar 21, 2017

Coverage Status

Coverage increased (+0.01%) to 94.356% when pulling c575fc5 on features/verbose-extend into e00be6b on master.

@HugoGiraudel

This comment has been minimized.

Member

HugoGiraudel commented Mar 22, 2017

Looks very good to me. :)

@pascalduez

This comment has been minimized.

Member

pascalduez commented Mar 22, 2017

How do we ship that change, patch, minor?

@HugoGiraudel

This comment has been minimized.

Member

HugoGiraudel commented Mar 22, 2017

@pascalduez pascalduez changed the title from Scope the empty data wanring under the verbose flag to Scope empty data warning under the verbose flag Mar 23, 2017

@pascalduez pascalduez merged commit d8075f7 into master Mar 23, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 94.356%
Details

@pascalduez pascalduez deleted the features/verbose-extend branch Mar 23, 2017

@pascalduez

This comment has been minimized.

Member

pascalduez commented Mar 23, 2017

+ sassdoc@2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment