Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates UI in WIHE equity tab #3500

Merged
merged 10 commits into from
Jul 29, 2024
Merged

updates UI in WIHE equity tab #3500

merged 10 commits into from
Jul 29, 2024

Conversation

kccrtv
Copy link
Collaborator

@kccrtv kccrtv commented Jul 26, 2024

Description and Motivation

This pull request includes ongoing UI updates aimed at enhancing the uniformity and consistency of the Health Equity Tracker application.

  • in the What is Health Equity? page include the removal of the outdated and unused “How do I join the movement?” section,
  • refactoring of the “Featured News” section to match the News section on the Landing Page

Has this been tested? How?

tests passing

Screenshots (if appropriate)

Old

Screenshot 2024-07-26 at 11 22 20 AM
Screenshot 2024-07-26 at 11 21 56 AM

Updated

wihe

Types of changes

  • New content or feature
  • Refactor / chore

New frontend preview link is below in the Netlify comment 😎

@kccrtv kccrtv changed the title Equity tab updates UI in WIHE equity tab Jul 26, 2024
Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for health-equity-tracker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d7cc5f7
🔍 Latest deploy log https://app.netlify.com/sites/health-equity-tracker/deploys/66a7be45dec4cf000832b229
😎 Deploy Preview https://deploy-preview-3500--health-equity-tracker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kccrtv kccrtv marked this pull request as ready for review July 26, 2024 19:17
Copy link
Collaborator

@benhammondmusic benhammondmusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! Please refactor that calculated tailwind color and add the new color to DesignTokens.ts instead; otherwise looks good to merge!

</>
}
/>
<section className='bg-[#F0F1EF]/[0.8] py-16'>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to avoid using computed values like bg-[#F0F1EF]/[0.8] where possible, and instead if there is a new color we want to use it should be directly added into DesignTokens.ts so we can stay aligned across all components

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this into its own file; makes everything so much more readable.

eriwarr and others added 2 commits July 29, 2024 10:07
…raphQL Fetch (SatcherInstitute#3498)

Added race measure IDs for “Non-Medical Drug Use,” updated code for relevant subtopics, increased GraphQL fetch timeout to 300 seconds, and removed unreliable 2023 data due to missing demographic breakdowns.
@kccrtv kccrtv merged commit ab6067b into SatcherInstitute:main Jul 29, 2024
12 checks passed
kccrtv added a commit to kccrtv/health-equity-tracker that referenced this pull request Jul 29, 2024
This pull request includes ongoing UI updates aimed at enhancing the
uniformity and consistency of the Health Equity Tracker application.
- in the `What is Health Equity? page` include the removal of the
outdated and unused “How do I join the movement?” section,
- refactoring of the “Featured News” section to match the News section
on the `Landing Page`

tests passing

![Screenshot 2024-07-26 at 11 22
20 AM](https://github.com/user-attachments/assets/adc20fd6-ff76-4b6f-b5ea-91ac41364840)
![Screenshot 2024-07-26 at 11 21
56 AM](https://github.com/user-attachments/assets/e4aa3e90-03ef-4a2d-a376-b6079a9515ae)

![wihe](https://github.com/user-attachments/assets/dc1318ef-0a30-43c2-aa73-0d61c871cdcf)

- New content or feature
- Refactor / chore

---------

Co-authored-by: Ben Hammond <benjamin.hammond@gmail.com>
Co-authored-by: Eric M Warren II <eric.m.warren1@gmail.com>
kccrtv added a commit to kccrtv/health-equity-tracker that referenced this pull request Aug 2, 2024
This pull request includes ongoing UI updates aimed at enhancing the
uniformity and consistency of the Health Equity Tracker application.
- in the `What is Health Equity? page` include the removal of the
outdated and unused “How do I join the movement?” section,
- refactoring of the “Featured News” section to match the News section
on the `Landing Page`

tests passing

![Screenshot 2024-07-26 at 11 22
20 AM](https://github.com/user-attachments/assets/adc20fd6-ff76-4b6f-b5ea-91ac41364840)
![Screenshot 2024-07-26 at 11 21
56 AM](https://github.com/user-attachments/assets/e4aa3e90-03ef-4a2d-a376-b6079a9515ae)

![wihe](https://github.com/user-attachments/assets/dc1318ef-0a30-43c2-aa73-0d61c871cdcf)

- New content or feature
- Refactor / chore

---------

Co-authored-by: Ben Hammond <benjamin.hammond@gmail.com>
Co-authored-by: Eric M Warren II <eric.m.warren1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants