Skip to content

✨ Include health tests for a PRD docker image #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulpatidar0191 merged 5 commits into from
Dec 5, 2023
Merged

✨ Include health tests for a PRD docker image #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f4a4d3
add dev parameter
rahulpatidar0191 Dec 4, 2023
8d5b440
add suggestion from code review
rahulpatidar0191 Dec 5, 2023
50d7c3b
remove empty line
rahulpatidar0191 Dec 5, 2023
4358cc4
remove unnecessary code
rahulpatidar0191 Dec 5, 2023
b85dc64
Update scripts/ValidateCode.sh
rahulpatidar0191 Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ inputs:
description: Name of the docker container for webapp
required: false
default: webapp

dev-arg:
description: Parameter to detect dev dependencies
required: false

runs:
using: "composite"
steps:
Expand All @@ -40,6 +43,7 @@ runs:
WORK_DIR: ${{ inputs.work-dir }}
FAST_PARA: ${{ inputs.fastapi-parameter }}
CONTAINER_NAME: ${{ inputs.container-name }}
DEV_ARG: ${{ inputs.dev-arg }}
run: ${{ github.action_path }}/scripts/ValidateCode.sh
shell: bash

Expand Down
8 changes: 6 additions & 2 deletions scripts/ValidateCode.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ docker-compose exec -T ${CONTAINER_NAME} python -c "import requests; f=open('${C
[ -d "/mnt/samba/${APP_NAME}" ] || mkdir -p "/mnt/samba/${APP_NAME}"
docker cp "$(docker-compose ps -q ${CONTAINER_NAME})":"/python/app/${CLEAN_BRANCH_NAME}_openapi.json" "/mnt/samba/${APP_NAME}/${CLEAN_BRANCH_NAME}_openapi.json"

if [[ -z $DEV_ARG ]]
then
exit 0
fi

echo "Clean up old reports"
rm -f unittesting.xml coverage.xml typing.xml typing-server.xml typing-integrations.xml

Expand All @@ -24,7 +29,6 @@ echo "Code tests"
if [[ $CONTAINER_NAME != "webapp" ]]; then
echo "flake8 tests" #TODO: remove the if else block once the errors on sb-pim are fixed
docker-compose exec -T ${CONTAINER_NAME} flake8; STATUS1=$? # For Sb-pim only

else
docker-compose exec -T ${CONTAINER_NAME} validatecodeonce; STATUS1=$?
docker cp "$(docker-compose ps -q ${CONTAINER_NAME})":/python/reports/typing.xml typing.xml
Expand All @@ -34,4 +38,4 @@ fi

## Return the status code
TOTAL=$((STATUS1))
exit $TOTAL
exit $TOTAL