From 195149a42ec5d18849701b16ee455a939a80540a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ely=C3=A9zer=20Mendes=20Rezende?= Date: Mon, 23 Mar 2015 09:21:33 -0300 Subject: [PATCH] Fix setup_proxy task In the previous refactor was checking for proxy username and password being None to add the installer options. That is not right as we want to set the username and password if they are not None. --- automation_tools/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/automation_tools/__init__.py b/automation_tools/__init__.py index 69f42fd29..e42c96056 100644 --- a/automation_tools/__init__.py +++ b/automation_tools/__init__.py @@ -151,9 +151,9 @@ def setup_proxy(run_katello_installer=True): 'katello-proxy-url': 'http://{0}'.format(proxy_info.hostname), 'katello-proxy-port': proxy_info.port, } - if proxy_info.username is None: + if proxy_info.username is not None: installer_options['katello-proxy-username'] = proxy_info.username - if proxy_info.password is None: + if proxy_info.password is not None: installer_options['katello-proxy-password'] = proxy_info.password if run_katello_installer: katello_installer(**installer_options)