Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Multiple fixes for ubuntu precise with pbuilder build #1

Merged
merged 2 commits into from

2 participants

Vedat Hallac madanyang
Vedat Hallac

Added some missing build-deps. Also fixed a linker error that reported undefined symbol errors from gtk and gdk, although they are present in the linker command line. The linker error was caused by the order of the libraries vs. the .o file.

Vedat Hallac added some commits
Vedat Hallac Add missing dependencies 7ddd092
Vedat Hallac Split LDFLAGS and LDLIBS to handle ubuntu linker failure
The default/implicit linking rule places LDFLAGS before the object. This causes
the build to break on some systems with undefined symbol errors. Placing the
libraries in LDLIBS pushes them after the .o file, and fixes the error.
f3c027e
madanyang
Collaborator

This must be ubuntu specific error, as with opensuse there are no problems.

Collaborator

Sorry you are right, as I had a local patch for the problem I forgot about the root cause

madanyang madanyang merged commit 0938769 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 4, 2013
  1. Add missing dependencies

    Vedat Hallac authored
  2. Split LDFLAGS and LDLIBS to handle ubuntu linker failure

    Vedat Hallac authored
    The default/implicit linking rule places LDFLAGS before the object. This causes
    the build to break on some systems with undefined symbol errors. Placing the
    libraries in LDLIBS pushes them after the .o file, and fixes the error.
This page is out of date. Refresh to see the latest.
Showing with 8 additions and 2 deletions.
  1. +2 −1  Makefile.in
  2. +6 −1 debian/control
3  Makefile.in
View
@@ -24,7 +24,8 @@
# the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
override CFLAGS += @GTK_CFLAGS@ @IMAGE_LOADER_CFLAGS@ @SAWFISH_CFLAGS@ -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED
-LDFLAGS = -Wl,-rpath @SAWFISH_CLIENT_LIB_DIR@ @SAWFISH_CLIENT_LIB_DIR@/client.so @GTK_LIBS@ @SAWFISH_LIBS@ @IMAGE_LOADER_LIBS@
+LDFLAGS = -Wl,-rpath @SAWFISH_CLIENT_LIB_DIR@
+LDLIBS = @SAWFISH_CLIENT_LIB_DIR@/client.so @GTK_LIBS@ @SAWFISH_LIBS@ @IMAGE_LOADER_LIBS@
all: sawfishpager pager.jlc
7 debian/control
View
@@ -6,9 +6,14 @@ Standards-Version: 3.6.2
Build-Depends: debhelper (>= 3.4.4),
librep-dev (>= 0.90.5),
libgtk2.0-dev (>= 2.24),
+ libgmp-dev,
sawfish (>= 1:1.8.0),
rep-gtk (>= 0.90.2),
- bc
+ bc,
+ autotools-dev,
+ automake1.11,
+ autoconf,
+ dh-autoreconf
Homepage: http://sawfish.wikia.com
Package: sawfish-pager
Something went wrong with that request. Please try again.