Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Multiple fixes for ubuntu precise with pbuilder build #1

Merged
merged 2 commits into from May 4, 2013

Conversation

Projects
None yet
2 participants

vhallac commented May 4, 2013

Added some missing build-deps. Also fixed a linker error that reported undefined symbol errors from gtk and gdk, although they are present in the linker command line. The linker error was caused by the order of the libraries vs. the .o file.

vhallac added some commits May 4, 2013

@vhallac vhallac Add missing dependencies 7ddd092
@vhallac vhallac Split LDFLAGS and LDLIBS to handle ubuntu linker failure
The default/implicit linking rule places LDFLAGS before the object. This causes
the build to break on some systems with undefined symbol errors. Placing the
libraries in LDLIBS pushes them after the .o file, and fixes the error.
f3c027e

This must be ubuntu specific error, as with opensuse there are no problems.

Sorry you are right, as I had a local patch for the problem I forgot about the root cause

@madanyang madanyang added a commit that referenced this pull request May 4, 2013

@madanyang madanyang Merge pull request #1 from vhallac/pull-req
Multiple fixes for ubuntu precise with pbuilder build
0938769

@madanyang madanyang merged commit 0938769 into SawfishWM:master May 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment