Better detection of transient windows during tilings #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were avoiding tiling transient windows such as dialogs by including in the tile-able window list only those windows of type 'default. But that excludes windows, such as CoreBird's, that are 'unframed. With this patch, we check for transients via the 'transient type.
|
That approach is not perfect, because other unframed windows like Conky for example will get tiled, too. Though that can be solved by using "never-tile" window-matcher. |
|
hmm, you're right. perhaps we could pre-configure a default never-tile |
|
is there anything you'd like i'd change to accept this patch? thanks! |
|
I'll let you know this weekend at the latest. |
|
I added 'never-tile to Conky and will roll-out another test-release with your pr commited. Thanks for your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were avoiding tiling transient windows such as dialogs by including
in the tile-able window list only those windows of type 'default. But
that excludes windows, such as CoreBird's, that are 'unframed. With
this patch, we check for transients via the 'transient type.