Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "The problem is that any sticky windows that have been focused… #49

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

mario-goulart
Copy link
Contributor

… once"

See
http://listengine.tuxfamily.org/lists.tuxfamily.org/sawfish/2015/06/msg00001.html
for more information

This reverts commit 6ad175d.

Conflicts:
lisp/sawfish/wm/util/window-order.jl

… once"

See
http://listengine.tuxfamily.org/lists.tuxfamily.org/sawfish/2015/06/msg00001.html
for more information

This reverts commit 6ad175d.

Conflicts:
	lisp/sawfish/wm/util/window-order.jl
@RobertZenz
Copy link
Contributor

I never did reply to your email, did I? Shame on me!

To answer your questions from way back then. The behavior I was talking about was that sticky windows would not receive the focus upon a workspace switch. My setup includes various sticky windows on a second monitor, and uppn switching workspaces it happened more often than not that these sticky windows would receive the focus instead of the "primary" windows on the first monitor.

One solution would be setting sticky windows as cycle-skip and unfocusable (or simply `mark-window-as-dock').

I think that would not match my use-case, as these windows should still be accessible for input (for example through the window cycle).

Another solution would be dynamically determining the most recently focused window (except sticky) upon entering workspaces.

That does sound like what I wanted anyway.

Unfortunately, the current solution is subject to race conditions, leading to an annoying problem when move-window-to is involved, and can't be easily fixed by users, since the problematic procedures in {enter,leave}-workspace-hook cannot be referenced, as they are not exported.

In that case I guess I'm all for reverting it, though, I can't speak about this bug. I mean the patch does exist and as I do local builds of Sawfish anyway, it doesn't matter to me.

@Nanolx Nanolx merged commit c2e2eb4 into SawfishWM:master Dec 20, 2021
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 4, 2022
1.13.0 "Bolero"
===============

   * Bug Fixes
        - Fix random resize issues with GTK+3 [GSR]

        - Improved KDE4/5 integration, prevent Plasma and KRunner
          windows to be tiled.  [Christopher Bratusek]

        - Update KDE5 session script, use 'startx11-plasma' instead of
          'startkde' [Christpher Bratusek]

        - Make 'shring-yank' recognise screen edges when shrinking or
          yanking windows, when the window crosses screen edges [Michal
          Nazarewicz]

        - Add support for '_NET_FRAME_EXTENTS' and
          '_NET_REQUEST_FRAME_EXTENTS' properties, fixing issues with
          HTML5 data element positioning in browsers, and several more
          [GSR]

        - Fix wrong detection of GNOME because of other DEs using an old
          GNOME-related envvar [Christopher Bratusek]

   * Build and Installation
        - Make build reproducible [Bernhard M. Wiedemann]

        - Fix cross compilation [Helmut Grohne]

        - Fix compilation with GCC10 [Kim B. Heino]
             x allow overriding 'build-info' build time, hostname and
               username.
             x avoid recreating theme tarball for every single file (the
               old code was erroneously recreating theme tarballs for
               each file contained thus calling 'tar' over 200 times to
               create 8 tarballs)
             x make 'DOC' file reproducibly
             x other improvements to make builds reproducible

        - Explicitely check for 'rep' binary, not just 'librep-dev'.
          [Christopher Bratusek]

        - First check for 'libgtk2.0-dev' then for 'rep-gtk-dev'.
          [Christopher Bratusek]

        - Only create session file directories for GNOME 2, KDE 4 or KDE
          5 if actually requested by user.  [Christopher Bratusek]

        - Makefile.in 'distclean' target no longer utilizes
          debian/rules, no longer removes finalized RPM spec file or
          Gentoo ebuild.  [Christopher Bratusek]

        - Remove dead code from 'build-info' [Ulrik Haugen]

        - Revert commit '6ad175d835aee85179259d7c02b3be152d3e4b86', "The
          problem is that any sticky windows that have been focused…",
          see SawfishWM/sawfish#49 [Mario
          Goulart]

   * New or changes features
        - Make 'match-window' allow specifying arbitrary functions as
          filter [Michal Nazarewicz]

   * Miscellaneous Changes
        - Various minor changes to the Makefiles, mostly replacing
          'gitlcean' target with 'distclean' target and adding '.PHONY'
          section.  Also move theme tarball creation into 'all' target,
          rather than 'install' target.  [Christopher Bratusek]

        - Make 'rename-window' throw an actual useful error message if
          no string (or no usable) was given.  [Christopher Bratusek]

        - Make 'resize-window-prompt' throw an actual useful error
          message if one (or both) of the input values was not given.
          [Christopher Bratusek]

        - Move several modules from 'sawfish.wm.prg' into the Sawfish
          Extras package [Christopher Bratusek]
             + 'diodon'
             + 'fehlstart'
             + 'idesk'
             + 'nm-applet'
             + 'pancake'

        - Filter out 'Trayer' in 'cabinet'.  [Christopher Bratusek]

        - Update Lumina integration.  [Christopher Bratusek]

        - Update GNOME integration and explicitely check for GNOME,
          respectively GNOME-classic [Christopher Bratusek]

        - Update KDE5 integration, check for plasma as desktop session
          [Christopher Bratusek]

        - Simplify Frame-Style README parsing.  [OpenBSD patch]

        - Update Japanese translation.  [Takeshi Hamasaki]

        - Update Korean translation.  [parkmino]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants