Add search functionality to home screen - #241
Merged
Merged
Conversation
Signed-off-by: Kilo Loco <kiloloco@me.com>
ohwhen
self-requested a review
July 20, 2020 19:37
hybridcattt
added a commit
that referenced
this pull request
Oct 7, 2020
* release/1.1: Try to always run build CI job Bumped version to 1.1 (6) [CHORE] Update slack-community link [FIX] Empty home on slow connection (#252) [FIX] Search results UI (#249) [FIX] Update slack contribution URL (#253) Making sure names fit on home for most text sizes (#251) #240 (#245) [FIX] Add missing accessibility in carousel collection view cells (#247) Changed Placeholder to black fists (#246) [FIX] Fix PersonCell image contraints (#244) [FIX] Fix HeroTextCell showing person details when selected (#242) Add search functionality to home screen (#241) Merging master -> development (#226) Update CONTRIBUTING.md (#233) [Chore] Added accessibility Identifier to MainTabBarController (#223) [CHORE] Gather SDWebImage usage under ImageService + dependency inject it (#222) [CHORE] Remove unused code (#221) [UI] BackgroundColor to resolve to SystemBackground, update usages for consistency. (#220) [CHORE] Adding Spanish as a locale (#219) # Conflicts: # SayTheirNames.xcodeproj/project.pbxproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to search for a person by name from the home screen.
Address issue 235