Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ParameterDiff detect changes to fx the Type of a PathParameter #22

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Hervian
Copy link

commented Mar 13, 2019

Minor changes to ParameterDiff and supporting class ListDiff to make the swagger-diff tool report when a parameter has been changed.
Example: Say a path parameter changes from type String to integer. This breaks backwards compatibility.

ListDiff change:
The ListDiff class previously attempted to remove elements from the 'increased' list using a call to equals. But since the two Parameters are not equal the element was not removed from the list (which it ought to be since the parameter is not new, only changed.

ParameterDiff change:
Previously the logic only handled BodyParameters.

@coveralls

This comment has been minimized.

Copy link

commented Mar 13, 2019

Pull Request Test Coverage Report for Build 63

  • 22 of 22 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 92.755%

Totals Coverage Status
Change from base Build 60: 0.2%
Covered Lines: 717
Relevant Lines: 773

💛 - Coveralls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.