Skip to content

Fix assumptions about config directory and Python runner#8

Merged
ScR4tCh merged 3 commits intoScR4tCh:masterfrom
c-w:misc-fixes
Jul 26, 2018
Merged

Fix assumptions about config directory and Python runner#8
ScR4tCh merged 3 commits intoScR4tCh:masterfrom
c-w:misc-fixes

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jul 24, 2018 •
edited
Loading

This pull request fixes two assumptions that this library currently has:

  • 7792f43 removes the assumption that the config root directory exists.
  • 8856d2c removes the assumption that the script is invoked via the standard Python runtime and enables running via tools such as the PyCharm debugger.
  • 8239305 adds documentation for how to run the project on Windows.

c-w added 3 commits July 24, 2018 16:39
@c-w
Remove assumption that config root exists
7792f43
@c-w
Enable invocation by third-party runners
8856d2c 
Currently the project fails if it's invoked by an external runner such
as the PyCharm debugger. This is because the click library gets confused
by the additional arguments passed to the debugger. Explicitly passing
the script's arguments to click fixes the issue.
@c-w
Add Windows setup instructions
8239305
@ScR4tCh
Copy link
Owner

ScR4tCh commented Jul 26, 2018

Great ! Thank you for contributing

@ScR4tCh ScR4tCh merged commit 7c16953 into ScR4tCh:master Jul 26, 2018
@c-w c-w deleted the misc-fixes branch July 26, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@c-w @ScR4tCh