Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assumptions about config directory and Python runner #8

Merged
merged 3 commits into from Jul 26, 2018
Merged

Fix assumptions about config directory and Python runner #8

merged 3 commits into from Jul 26, 2018

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jul 24, 2018

This pull request fixes two assumptions that this library currently has:

  • 7792f43 removes the assumption that the config root directory exists.
  • 8856d2c removes the assumption that the script is invoked via the standard Python runtime and enables running via tools such as the PyCharm debugger.
  • 8239305 adds documentation for how to run the project on Windows.
c-w added 3 commits Jul 24, 2018
Currently the project fails if it's invoked by an external runner such
as the PyCharm debugger. This is because the click library gets confused
by the additional arguments passed to the debugger. Explicitly passing
the script's arguments to click fixes the issue.
@ScR4tCh
Copy link
Owner

@ScR4tCh ScR4tCh commented Jul 26, 2018

Great ! Thank you for contributing

Loading

@ScR4tCh ScR4tCh merged commit 7c16953 into ScR4tCh:master Jul 26, 2018
@c-w c-w deleted the misc-fixes branch Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants