New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module was occupied by C++ modules TS keywords #1

Closed
xiangzhai opened this Issue Oct 18, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@xiangzhai
Copy link
Contributor

xiangzhai commented Oct 18, 2017

MODULES_KEYWORD(module)

kw_module = &IdentTable.get("module");

case tok::kw_module:

Do you remember C++Now 2012? I do. There was a keynote on Modules in C++ by Daveed Vandevoorde. Cool, back then clang had an early implementation, a little strange with module files. Last year I learned from Chandler Carruth at Meeting C++ that the motivation behind this was to not touch C++, and not introduce any non standard things in order to support modules. Later, a C++ Standard module version for clang would not need these module files. But back to 2012. Doug Gregor from apple also gave a talk on modules in December 2012 at an llvm meeting.

So it needs to rename module to qmodule, thoughts?

@xiangzhai xiangzhai changed the title `module` was occupied by C++ modules TS keywords module was occupied by C++ modules TS keywords Oct 18, 2017

@xiangzhai xiangzhai added this to the release_60 milestone Oct 18, 2017

xiangzhai added a commit that referenced this issue Oct 18, 2017

@xiangzhai xiangzhai added the question label Oct 25, 2017

@xiangzhai xiangzhai closed this Oct 25, 2017

xiangzhai pushed a commit that referenced this issue Dec 7, 2017

[WebAssembly] Pass through --undefined to Wasm LLD
This is a follow-on to D40724 (Wasm entrypoint changes #1,
add `--undefined` argument to LLD).

Patch by Nicholas Wilson

Differential Revision: https://reviews.llvm.org/D40739

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@319623 91177308-0d34-0410-b5e6-96231b3b80d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment