New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to usage of Compile-time dependency injection #400

Closed
ScalaWilliam opened this Issue Jun 29, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@ScalaWilliam
Owner

ScalaWilliam commented Jun 29, 2017

So that:

  • We understand the tradeoffs and gain knowledge
  • Improve robustness
    • As I've had many runtime failures so far
    • As there's no single entry point, which still feels weird

The work must be done incrementally. Here, the first unit of work is: "Application Loader module" I will pay for this work. http://work.scalawilliam.com/Play-Compile-DI/

If nobody is interested, I'll do this myself when I find the time.

$50.00

Scope

Implement an application loader. Keep other parts of the system in Runtime DI - I want incremental work only - we migrate those parts later, separately.

Incremental work only, no large PRs :-)

@ScalaWilliam ScalaWilliam self-assigned this Jun 29, 2017

@ScalaWilliam

This comment has been minimized.

Show comment
Hide comment
@ScalaWilliam

ScalaWilliam Jul 18, 2017

Owner

@omainegra is interested in taking on this piece of work.

Owner

ScalaWilliam commented Jul 18, 2017

@omainegra is interested in taking on this piece of work.

@ScalaWilliam

This comment has been minimized.

Show comment
Hide comment
@ScalaWilliam

This comment has been minimized.

Show comment
Hide comment
@ScalaWilliam

ScalaWilliam Jul 18, 2017

Owner

@omainegra I recommend to open a PR as soon as you start, so you get earlier feedback from me.

Many smaller commits will be better.

Owner

ScalaWilliam commented Jul 18, 2017

@omainegra I recommend to open a PR as soon as you start, so you get earlier feedback from me.

Many smaller commits will be better.

@omainegra

This comment has been minimized.

Show comment
Hide comment
@omainegra

omainegra Jul 18, 2017

Contributor

@ScalaWilliam First PR done, just the Application Loader with fallback to Runtime DI, as said in the specifications of the job.

Contributor

omainegra commented Jul 18, 2017

@ScalaWilliam First PR done, just the Application Loader with fallback to Runtime DI, as said in the specifications of the job.

@ScalaWilliam

This comment has been minimized.

Show comment
Hide comment
@ScalaWilliam

ScalaWilliam Jul 20, 2017

Owner

Closed by: #404

Owner

ScalaWilliam commented Jul 20, 2017

Closed by: #404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment