New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$20-$28: Create Dockerfile that builds everything with `make` #98

Closed
ScalaWilliam opened this Issue Nov 4, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@ScalaWilliam
Owner

ScalaWilliam commented Nov 4, 2017

So that:

  • I can build the site from within a Docker image, and thus build previews independently - ie #97
  • Travis build would be lighter and less Travis-specific

Contains make, php, composer.

Save the Docker image as build/Dockerfile. The way I see this working is by:

$ git clone https://github.com/ScalaWilliam/ScalaWilliam.com.git sw
$ cd sw
$ docker build -t sw-build build/Dockerfile
$ docker run -v $PWD:/sw -it sw-build bash -c 'cd /sw/ && composer install && make'
$ echo $?
0

I'll pay US$20 for this as specified on ScalaWilliam Work item: Dockerfile for website.
To take on this, comment "I agree to the ScalaWilliam Work rules and am taking on this task".

$8 bonus if completed correctly before Saturday 4 Nov 23:59:59 UTC!
Please correct me if there're any mistakes.

@ScalaWilliam ScalaWilliam changed the title from Create Dockerfile that builds everything with build.sh to Create Dockerfile that builds everything with `make` Nov 4, 2017

@ScalaWilliam ScalaWilliam changed the title from Create Dockerfile that builds everything with `make` to $20: Create Dockerfile that builds everything with `make` Nov 4, 2017

@ScalaWilliam ScalaWilliam changed the title from $20: Create Dockerfile that builds everything with `make` to $20-$28: Create Dockerfile that builds everything with `make` Nov 4, 2017

@philicious

This comment has been minimized.

Show comment
Hide comment
@philicious

philicious Nov 6, 2017

Contributor

hi @ScalaWilliam .. came here via Twitter ..

I agree to the ScalaWilliam Work rules and am taking on this task

docker run --rm -it -v $PWD:/app composer install && make

using https://hub.docker.com/r/library/composer/ .. so no need to roll your own Dockerfile. Unless you need customizations to compose et.al.

Contributor

philicious commented Nov 6, 2017

hi @ScalaWilliam .. came here via Twitter ..

I agree to the ScalaWilliam Work rules and am taking on this task

docker run --rm -it -v $PWD:/app composer install && make

using https://hub.docker.com/r/library/composer/ .. so no need to roll your own Dockerfile. Unless you need customizations to compose et.al.

@ScalaWilliam

This comment has been minimized.

Show comment
Hide comment
@ScalaWilliam

ScalaWilliam Nov 8, 2017

Owner

Not quite, that doesn't work, make must run inside the container.

Owner

ScalaWilliam commented Nov 8, 2017

Not quite, that doesn't work, make must run inside the container.

@philicious

This comment has been minimized.

Show comment
Hide comment
@philicious

philicious Nov 8, 2017

Contributor

@ScalaWilliam ah ye you are right. I was a bit quick on this. see my PR

Contributor

philicious commented Nov 8, 2017

@ScalaWilliam ah ye you are right. I was a bit quick on this. see my PR

@ScalaWilliam ScalaWilliam closed this in #99 Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment