New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: collaborators-add should be less resource-expensive #137

Closed
Zyko0 opened this Issue Sep 17, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@Zyko0
Contributor

Zyko0 commented Sep 17, 2015

When you want to complete collaborators-add command, it will show you every collaborator you are working with, from any of your other apps.
If you manage to have a lot of apps, the client itself will make the collaborators-list request to Scalingo API for EACH app, which will take time.

An improvement would be to do asynchronous requests (even if it's hard in its current implementation), or do a new server-side function, maybe?

@Soulou Soulou closed this in f5f1828 Sep 21, 2015

Soulou added a commit that referenced this issue Sep 21, 2015

Merge pull request #143 from Zyko0/fix_issue_137
Fix #137 : collaborators-add completion now uses goroutines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment