New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[run] It should forward the exit code of the command #203

Closed
Soulou opened this Issue Mar 4, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@Soulou
Member

Soulou commented Mar 4, 2016

No description provided.

@dlupu

This comment has been minimized.

Show comment
Hide comment
@dlupu

dlupu Apr 1, 2016

Run again into this issue today

-----> Connecting to container [one-off-1]...  �-�\�|� 
-----> Process 'bundle exec rake cache:clear' is starting...  �-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/� 

rake aborted!

Don't know how to build task 'cache:clear' (see --tasks)
(See full trace by running task with --trace)

The CI considered this as a valid instruction and did not warn us there was a problem on deploy.

dlupu commented Apr 1, 2016

Run again into this issue today

-----> Connecting to container [one-off-1]...  �-�\�|� 
-----> Process 'bundle exec rake cache:clear' is starting...  �-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/� 

rake aborted!

Don't know how to build task 'cache:clear' (see --tasks)
(See full trace by running task with --trace)

The CI considered this as a valid instruction and did not warn us there was a problem on deploy.

@Soulou

This comment has been minimized.

Show comment
Hide comment
@Soulou

Soulou Apr 1, 2016

Member

I've started implementing the server-side necessary work for this feature to be implemented. It will be present in the CLI 1.3 (next release)

Member

Soulou commented Apr 1, 2016

I've started implementing the server-side necessary work for this feature to be implemented. It will be present in the CLI 1.3 (next release)

@Soulou

This comment has been minimized.

Show comment
Hide comment
@Soulou

Soulou Apr 1, 2016

Member

Working in our staging environment:

└> ./scalingo -a app run make ; echo $?
-----> Connecting to container [one-off-3]...  
-----> Process 'make' is starting...  

make: *** No targets specified and no makefile found.  Stop.
2

└> ./scalingo -a app run ls / ; echo $?
-----> Connecting to container [one-off-3]...  
-----> Process 'ls /' is starting...  

app  bin  boot  build  buildpacks  dev  etc  home  lib  lib64  media  mnt  opt  proc  repo  root  run  sbin  srv  start  sys  tmp  usr  var
0
Member

Soulou commented Apr 1, 2016

Working in our staging environment:

└> ./scalingo -a app run make ; echo $?
-----> Connecting to container [one-off-3]...  
-----> Process 'make' is starting...  

make: *** No targets specified and no makefile found.  Stop.
2

└> ./scalingo -a app run ls / ; echo $?
-----> Connecting to container [one-off-3]...  
-----> Process 'ls /' is starting...  

app  bin  boot  build  buildpacks  dev  etc  home  lib  lib64  media  mnt  opt  proc  repo  root  run  sbin  srv  start  sys  tmp  usr  var
0

@Soulou Soulou closed this in 2093157 Apr 1, 2016

Soulou added a commit that referenced this issue Apr 1, 2016

Merge pull request #205 from Scalingo/forward-exit-code
Once the one-off container has stopped, wait for exit code and forward it to current shell Fixes #203
@dlupu

This comment has been minimized.

Show comment
Hide comment
@dlupu

dlupu Apr 1, 2016

great !

dlupu commented Apr 1, 2016

great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment