New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable version update check #361

Closed
Horgix opened this Issue Jun 7, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@Horgix

Horgix commented Jun 7, 2018

From why I understand from the update warning by the CLI, the strace I ran on it, and the check.go sources, it looks like the CLI send a request to cli-dl.scalingo.io/version everytime to know if it's up-to-date.

It also looks like it's currently not possible to disable this check, and I know that some people don't really like CLI that "call home" (I'm among them, especially when running a --help or --version) 😉

It would be cool to be able to disable it, for example with an environment variable (that's what Hashicorp are doing on Packer). The best would be to have it opt-in but I think you'll prefer to keep it ON by default don't you?

If you're OK with this, I would like to send the PR implementing it 🙂

@Soulou

This comment has been minimized.

Member

Soulou commented Jun 8, 2018

Hi there, we're completely ok with this. To be fully transparent we're not doing anything from this call to cli-dl (no stat for instance), its purpose is only to notify when a new version is released, waiting for an auto-upgrade mecanism to be developed. (Which will be disablable ;-))

@Horgix

This comment has been minimized.

Horgix commented Jun 8, 2018

I definitely trust you on that and even if you were doing stats on it it wouldn't be that much of a problem anyway. Just thought I would open this since I was surprised to see a --help doing HTTP requests 😄

I just saw #174, #175 and #309 about the auto-upgrade. Definitely not a fan of this and would definitely appreciate if it was possible to disable this kind of thing!

@yannski

This comment has been minimized.

Contributor

yannski commented Jun 8, 2018

@Horgix you're right, the help command should not do any HTTP requests, there should be a dedicated subcommand for version checking and the auto-upgrade should be disconnectable

Soulou added a commit that referenced this issue Jul 5, 2018

@EtienneM EtienneM closed this in #368 Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment