New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification v2 #301

Merged
merged 19 commits into from Jul 11, 2017

Conversation

Projects
None yet
2 participants
@MrYawe
Contributor

MrYawe commented Jun 21, 2017

Notifier:

  • Create command
  • Update command
  • Delete command
  • List command
  • Show details command

Notification platform:

  • List command
@MrYawe

This comment has been minimized.

Contributor

MrYawe commented Jun 22, 2017

@Soulou Should we delete notification command ?

@MrYawe MrYawe changed the title from Notification v2 [WIP] to Notification v2 Jul 6, 2017

@MrYawe MrYawe self-assigned this Jul 7, 2017

@MrYawe MrYawe added reviewable and removed work in progress labels Jul 7, 2017

@MrYawe MrYawe requested a review from Soulou Jul 7, 2017

@MrYawe MrYawe added work in progress and removed reviewable labels Jul 7, 2017

@MrYawe MrYawe added reviewable and removed work in progress labels Jul 7, 2017

var (
NotificationPlatformListCommand = cli.Command{
Name: "platforms-list",

This comment has been minimized.

@Soulou

Soulou Jul 11, 2017

Member

I'm not super fan of the command name, notification-platforms would be better no?

This comment has been minimized.

@Soulou

Soulou Jul 11, 2017

Member

I made the choice to transform it to notification-platforms as stated by the variable name ;)

@Soulou Soulou merged commit 94982a4 into master Jul 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment