Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duration-before-trigger flag to alert creation and update #407

Merged
merged 6 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@EtienneM
Copy link
Member

commented Apr 1, 2019

EtienneM added some commits Mar 29, 2019

Revert changes to RemindEvery
Input is now a string parseable with time.ParseDuration

@EtienneM EtienneM marked this pull request as ready for review Apr 8, 2019

@EtienneM EtienneM requested a review from Soulou Apr 8, 2019

@EtienneM EtienneM added the reviewable label Apr 8, 2019

@Soulou

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Example of output?

@EtienneM

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2019

> ./cli -a gregfregegre alerts
+-----------------------------------------+--------+----------------+--------+----------------------+----------+
|                   ID                    | ACTIVE | CONTAINER TYPE | METRIC |        LIMIT         | DURATION |
+-----------------------------------------+--------+----------------+--------+----------------------+----------+
| al-dc6450de-7331-486d-89a2-409e17424c80 | true   | web            | rpm    | triggers above 15.00 | 3m0s     |
+-----------------------------------------+--------+----------------+--------+----------------------+----------+
@Soulou

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Could we have this:

> ./cli -a gregfregegre alerts
+-----------------------------------------+--------+----------------+--------+----------------------+
|                   ID                    | ACTIVE | CONTAINER TYPE | METRIC |        TRIGGER       |
+-----------------------------------------+--------+----------------+--------+----------------------+
| al-dc6450de-7331-486d-89a2-409e17424c80 | true   | web            | rpm    | >= 15.00 (for 3m0s)  |
+-----------------------------------------+--------+----------------+--------+----------------------+

To me it's much clearer semantically, do you agree?

@EtienneM

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2019

+-----------------------------------------+--------+----------------+--------+--------------------+
|                   ID                    | ACTIVE | CONTAINER TYPE | METRIC |       LIMIT        |
+-----------------------------------------+--------+----------------+--------+--------------------+
| al-dc6450de-7331-486d-89a2-409e17424c80 | true   | web            | rpm    | ≥ 15.00 (for 3m0s) |
+-----------------------------------------+--------+----------------+--------+--------------------+

@EtienneM EtienneM force-pushed the fix/alerter/93/alert_delay branch from a46ffb1 to 8467d4b Apr 12, 2019

@Soulou Soulou merged commit 7372487 into master Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.