Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to gitremote #434

Merged
merged 3 commits into from Jul 3, 2019

Conversation

Projects
None yet
2 participants
@EtienneM
Copy link
Member

commented Jul 3, 2019

Fix #432

@EtienneM EtienneM marked this pull request as ready for review Jul 3, 2019

@EtienneM EtienneM added the reviewable label Jul 3, 2019

@EtienneM EtienneM requested a review from Soulou Jul 3, 2019

}
}

return repos
}

func scalingoRemotes(directory string) (gitremote.Remotes, error) {
matchedRemotes := make(gitremote.Remotes, 0)

This comment has been minimized.

Copy link
@Soulou

Soulou Jul 3, 2019

Member

Are you sure there is no regression here as the 'matchedRemotes' filter has been deleted?

@Soulou

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

"gopkg.in/src-d/go-git.v4/config" has not been added to dep/vendored

@EtienneM

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

"gopkg.in/src-d/go-git.v4/config" has not been added to dep/vendored

It is already in the vendor folder

EtienneM added some commits Jul 2, 2019

@EtienneM EtienneM force-pushed the fix/432/remove_gitremote_dependency branch from 3da1dd2 to de205ab Jul 3, 2019

@EtienneM EtienneM requested a review from Soulou Jul 3, 2019

@Soulou Soulou merged commit e3d4c05 into master Jul 3, 2019

@EtienneM EtienneM deleted the fix/432/remove_gitremote_dependency branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.