Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Git remote URL parsing to detect app name #443

Merged
merged 3 commits into from Jul 15, 2019

Conversation

@EtienneM
Copy link
Member

commented Jul 11, 2019

Fix #442

EtienneM added some commits Jul 11, 2019

@EtienneM EtienneM marked this pull request as ready for review Jul 11, 2019

@EtienneM EtienneM added the reviewable label Jul 11, 2019

@EtienneM EtienneM requested a review from Soulou Jul 11, 2019

@Soulou

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

It seems quite easy to test, can you add one?

@EtienneM

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

Not that easy as it calls scalingoRemotes which uses the Git lib to extract the Git repo information and we have no interface to mock it..

@Soulou

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

You can separate in two functions, and one is taking the name of the remote where you do the test?

@EtienneM EtienneM force-pushed the fix/442/app_detection_git branch from 47f4e6e to 2986d7a Jul 11, 2019

@EtienneM EtienneM requested review from Soulou and removed request for Soulou Jul 12, 2019

@Soulou Soulou merged commit 37bfe89 into master Jul 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.