Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add periodic backups configuration commands #455

Merged
merged 7 commits into from Jul 23, 2019

Conversation

@EtienneM
Copy link
Member

@EtienneM EtienneM commented Jul 22, 2019

$ scalingo --app my-app --addon ad-d4903c5a-7b38-4fca-950a-54a34ae84ca4 backups-config --disable-scheduling
-----> Periodic backups are disabled

$ scalingo --app my-app --addon ad-d4903c5a-7b38-4fca-950a-54a34ae84ca4 backups-config --schedule-at 3
-----> Periodic backups will be done daily at 3:00 CEST

Fix #454

@EtienneM EtienneM force-pushed the fix/454/periodic_backups_config branch 3 times, most recently from 72d3f8d to 40bf046 Jul 22, 2019
@EtienneM EtienneM marked this pull request as ready for review Jul 22, 2019
@EtienneM EtienneM requested a review from Soulou Jul 22, 2019
cmd/databases.go Outdated
Usage: "Configure the periodic backups of a database",
Flags: []cli.Flag{appFlag, addonFlag, cli.IntFlag{
Name: "schedule-at",
Usage: "Enable daily backups and schedule them at the specified hour of the day (UTC)",
Copy link
Member

@Soulou Soulou Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use the local timezone?

Loading

Copy link
Member Author

@EtienneM EtienneM Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's probably better UX

Loading

Copy link
Member Author

@EtienneM EtienneM Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here your are:

$ scalingo --app my-app --addon ad-d4903c5a-7b38-4fca-950a-54a34ae84ca4 backups-config --schedule-at 3
-----> Periodic backups will be done daily at 3:00 CEST

Loading

@EtienneM EtienneM force-pushed the fix/454/periodic_backups_config branch from 77f4341 to 6c0a8fc Jul 22, 2019
@Soulou
Copy link
Member

@Soulou Soulou commented Jul 22, 2019

And if no flag is used, shoudn't we display the current backups configuration?

Loading

@EtienneM EtienneM force-pushed the fix/454/periodic_backups_config branch from 345a5de to 6d1c95e Jul 22, 2019
@EtienneM EtienneM force-pushed the fix/454/periodic_backups_config branch 2 times, most recently from 00d07b3 to 120c397 Jul 22, 2019
@yannski
Copy link
Member

@yannski yannski commented Jul 22, 2019

Loading

@EtienneM EtienneM requested a review from Soulou Jul 22, 2019
@EtienneM EtienneM force-pushed the fix/454/periodic_backups_config branch from 120c397 to 5d72bbc Jul 22, 2019
@Soulou
Copy link
Member

@Soulou Soulou commented Jul 23, 2019

@EtienneM what so you think, local time by default but ability to write "full tz" like heroku?

Loading

@EtienneM
Copy link
Member Author

@EtienneM EtienneM commented Jul 23, 2019

@EtienneM what so you think, local time by default but ability to write "full tz" like heroku?

Yep I will do that

And I like that Heroku name the option unschedule. I will also update this command name.

Loading

@EtienneM EtienneM requested review from Soulou and removed request for Soulou Jul 23, 2019
@EtienneM EtienneM force-pushed the fix/454/periodic_backups_config branch from 33a3b39 to cec9050 Jul 23, 2019
@Soulou Soulou merged commit 38b1b52 into master Jul 23, 2019
@EtienneM EtienneM deleted the fix/454/periodic_backups_config branch May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants