Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new SCM events #467

Merged
merged 1 commit into from Aug 22, 2019
Merged

Add support for new SCM events #467

merged 1 commit into from Aug 22, 2019

Conversation

@EtienneM
Copy link
Member

@EtienneM EtienneM commented Aug 22, 2019

$ scalingo --app test-etienne timeline
* Wed Aug 21 2019 13:13:20 - Link Scm      - app has been linked to repository 'EtienneM/sample-go-martini' <etiennem (etienne@scalingo.com)>
* Wed Aug 21 2019 13:11:58 - Unlink Scm    - app has been unlinked from repository 'EtienneM/sample-go-martini' <etiennem (etienne@scalingo.com)>

Fix #466

@EtienneM EtienneM force-pushed the fix/466/new_scm_events branch from 3c3a574 to fa6fd61 Aug 22, 2019
@EtienneM EtienneM marked this pull request as ready for review Aug 22, 2019
@EtienneM EtienneM requested a review from Soulou Aug 22, 2019
@Soulou
Copy link
Member

@Soulou Soulou commented Aug 22, 2019

There is a mess in the PR

Loading

Copy link
Member

@Soulou Soulou left a comment

Messy PR (files edited from old commits)

Loading

@EtienneM
Copy link
Member Author

@EtienneM EtienneM commented Aug 22, 2019

Euh... no 😅

It's just an update from go-scalingo v2.X to go-scalingo v3.X

Loading

@EtienneM EtienneM requested a review from Soulou Aug 22, 2019
@Soulou
Copy link
Member

@Soulou Soulou commented Aug 22, 2019

Ooooh my bad I didn't get this, I was seeing a lot of new things, thinking it was go-scalingo, it's a deps upgrade then LGTM

Loading

@EtienneM EtienneM merged commit 6e7552c into master Aug 22, 2019
@EtienneM EtienneM deleted the fix/466/new_scm_events branch Aug 22, 2019
EtienneM added a commit that referenced this issue Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants