Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message if unknown app suggest to try on a different region #519

Merged
merged 2 commits into from Feb 7, 2020

Conversation

@EtienneM
Copy link
Member

EtienneM commented Feb 4, 2020

╰─$ go build -o scalingo-cli ./scalingo && ./scalingo-cli --app unknown-app run bash
 !     The application was not found on the region agora-fr1. You can try on a different region with 'scalingo --region osc-fr1 ...'.

Related to Scalingo/one-stop-shop#34

@EtienneM EtienneM added the reviewable label Feb 4, 2020
@EtienneM EtienneM force-pushed the fix/one-stop-shop/34/error_app_not_found branch from f7cb0ad to f1ad466 Feb 4, 2020
@EtienneM EtienneM requested a review from Soulou Feb 4, 2020
Copy link
Member

Soulou left a comment

I would put the error message on two lines, thoughts?

@EtienneM

This comment has been minimized.

Copy link
Member Author

EtienneM commented Feb 4, 2020

The two lines version looks, indeed, much better:

╰─$ go build -o scalingo-cli ./scalingo && ./scalingo-cli --app unknown-app run bash
 !     The application was not found on the region agora-fr1.
 !     You can try on a different region with 'scalingo --region osc-fr1 ...'.
@EtienneM EtienneM requested a review from Soulou Feb 5, 2020
@mackwic

This comment has been minimized.

Copy link

mackwic commented Feb 5, 2020

So eager to see it live ! :D

@Soulou Soulou merged commit b92053a into master Feb 7, 2020
1 check passed
1 check passed
continuous-integration/codeship Build succeeded
Details
@EtienneM EtienneM deleted the fix/one-stop-shop/34/error_app_not_found branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.