Fix/cli/525/git setup remote already exists #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soulou
requested changes
Mar 11, 2020
cmd/git.go
Outdated
| @@ -29,7 +32,8 @@ var ( | |||
| } | |||
|
|
|||
| err := git.Setup(appdetect.CurrentApp(c), git.SetupParams{ | |||
| RemoteName: c.String("r"), | |||
| RemoteName: c.String("r"), | |||
There was a problem hiding this comment.
Please use the long flag name for a better readability
git/setup.go
Outdated
| errWrapped := utils.WrapError(err, "fail to create the Git remote") | ||
| if err == git.ErrRemoteExists { | ||
| errWrapped = utils.WrapError(err, "fail to create the Git remote"+ | ||
| " (maybe you want use the force option to override the remote url)") |
There was a problem hiding this comment.
Fail to configure git repository, "%v" remote already exists. (Use --force option to override)
Soulou
reviewed
Mar 11, 2020
Actually something is still missing here, usually when we modify the CLI behavior, we add in the PR a console output showing the new feature/fix. Could you please add that?
|
|
|
As spoken orally, the error displayed to the user is not right (repetition), to make it cleaner, it requires some changes in way we're handling error and probably to modify https://github.com/Scalingo/go-scalingo/errors |
|
After disucssion, we accept this version, better error management will be handled later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Offer a option --force to the command git-setup to allow the user to override the current remote handle with a new remote url
Fix #525
User
Tech