Log drains add command #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curzolapierre
changed the title
curzolapierre
changed the title
curzolapierre
force-pushed
the
feature/552/add_log_drains_add_cmd
branch
3 times, most recently
from
dc3d45f
to
0516e5c
Compare
curzolapierre
force-pushed
the
feature/552/add_log_drains_add_cmd
branch
from
0516e5c
to
5a2905a
Compare
EtienneM
requested changes
May 15, 2020
Please rebase with master to resolve the conflict
When you create a PR on the CLI, please add in the first comment some examples of execution of this new command. It helps for the review to visualize the output.
curzolapierre
force-pushed
the
feature/552/add_log_drains_add_cmd
branch
2 times, most recently
from
61ea958
to
f52344f
Compare
curzolapierre
force-pushed
the
feature/552/add_log_drains_add_cmd
branch
2 times, most recently
from
9f59260
to
7879343
Compare
EtienneM
requested changes
May 18, 2020
Just a small idea for the status message. Otherwise LGTM. I will not merge until we release a new version of go-scalingo.
EtienneM
reviewed
May 18, 2020
I just noticed that the README displays the CLI help message. As you added a couple of commands (list and add a log drain), can you update the README accordingly?
EtienneM
reviewed
May 20, 2020
curzolapierre
force-pushed
the
feature/552/add_log_drains_add_cmd
branch
from
aa6f4d7
to
0bc236f
Compare
EtienneM
reviewed
May 20, 2020
EtienneM
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
log-drains-addcommandExample
$ scalingo log-drains-add --app sample-go-martini --type papertrail --host logs.papertrailapp.com --port 12345 -----> Log Drain tcp+tls://logs.papertrailapp.com:12345 has been add to the applicationFix #552