Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log drains add command #561

Merged
merged 6 commits into from May 20, 2020
Merged

Log drains add command #561

merged 6 commits into from May 20, 2020

Conversation

curzolapierre
Copy link
Contributor

@curzolapierre curzolapierre commented Apr 30, 2020

  • Add log-drains-add command

Example

$ scalingo log-drains-add --app sample-go-martini --type papertrail --host logs.papertrailapp.com --port 12345
-----> Log Drain tcp+tls://logs.papertrailapp.com:12345 has been add to the application

Fix #552

@curzolapierre curzolapierre requested a review from EtienneM Apr 30, 2020
@curzolapierre curzolapierre self-assigned this Apr 30, 2020
@curzolapierre curzolapierre changed the title Feature/552/add log drains add comand Feature/552/add log drains add command Apr 30, 2020
@curzolapierre curzolapierre removed the request for review from EtienneM Apr 30, 2020
@curzolapierre curzolapierre changed the title Feature/552/add log drains add command Log drains add command Apr 30, 2020
@curzolapierre curzolapierre force-pushed the feature/552/add_log_drains_add_cmd branch 3 times, most recently from dc3d45f to 0516e5c Compare May 13, 2020
@curzolapierre curzolapierre requested a review from EtienneM May 14, 2020
@curzolapierre curzolapierre force-pushed the feature/552/add_log_drains_add_cmd branch from 0516e5c to 5a2905a Compare May 14, 2020
Copy link
Member

@EtienneM EtienneM left a comment

Please rebase with master to resolve the conflict
When you create a PR on the CLI, please add in the first comment some examples of execution of this new command. It helps for the review to visualize the output.

log_drains/add.go Outdated Show resolved Hide resolved
log_drains/add.go Outdated Show resolved Hide resolved
cmd/log_drains.go Outdated Show resolved Hide resolved
cmd/log_drains.go Outdated Show resolved Hide resolved
cmd/log_drains.go Show resolved Hide resolved
log_drains/add.go Outdated Show resolved Hide resolved
@curzolapierre curzolapierre force-pushed the feature/552/add_log_drains_add_cmd branch 2 times, most recently from 61ea958 to f52344f Compare May 15, 2020
@curzolapierre curzolapierre requested a review from EtienneM May 15, 2020
@curzolapierre curzolapierre force-pushed the feature/552/add_log_drains_add_cmd branch 2 times, most recently from 9f59260 to 7879343 Compare May 15, 2020
Copy link
Member

@EtienneM EtienneM left a comment

Just a small idea for the status message. Otherwise LGTM. I will not merge until we release a new version of go-scalingo.

log_drains/add.go Outdated Show resolved Hide resolved
Copy link
Member

@EtienneM EtienneM left a comment

I just noticed that the README displays the CLI help message. As you added a couple of commands (list and add a log drain), can you update the README accordingly?

Gopkg.toml Outdated Show resolved Hide resolved
@curzolapierre curzolapierre requested a review from EtienneM May 20, 2020
@curzolapierre curzolapierre force-pushed the feature/552/add_log_drains_add_cmd branch from aa6f4d7 to 0bc236f Compare May 20, 2020
README.md Outdated Show resolved Hide resolved
@EtienneM EtienneM merged commit 363c29e into master May 20, 2020
1 check passed
@EtienneM EtienneM deleted the feature/552/add_log_drains_add_cmd branch May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants