Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log drains from db #577

Merged
merged 5 commits into from Jul 3, 2020
Merged

Conversation

curzolapierre
Copy link
Contributor

@curzolapierre curzolapierre commented Jul 1, 2020

Command: remove a log drain from a DB (with addon uuid)

Example:
With an application app-1 with 2 addons and

$ scalingo --app app-1 log-drains-remove tcp+tls://logs.papertrailapp.com:10303
-----> Log drain tcp+tls://logs.papertrailapp.com:10303 has been deleted from the application app-1
-----> Log drain tcp+tls://logs.papertrailapp.com:10303 has been deleted from the addon Scalingo Redis
-----> Log drain tcp+tls://logs.papertrailapp.com:10303 has been deleted from the addon Scalingo Mongo

$ scalingo --app app-1 --addon ad-1234567-1123 log-drains-remove tcp+tls://logs.papertrailapp.com:10303
-----> Log drain tcp+tls://logs.papertrailapp.com:10303 has been deleted from the addon Scalingo Redis

$ scalingo --app app-1 --only-app log-drains-remove tcp+tls://logs.papertrailapp.com:10303
-----> Log drain tcp+tls://logs.papertrailapp.com:10303 has been deleted from the application app-1

Fix #576

@curzolapierre curzolapierre self-assigned this Jul 1, 2020
@curzolapierre curzolapierre requested a review from EtienneM Jul 1, 2020
cmd/log_drains.go Outdated Show resolved Hide resolved
cmd/log_drains.go Outdated Show resolved Hide resolved
cmd/log_drains.go Outdated Show resolved Hide resolved
cmd/log_drains.go Outdated Show resolved Hide resolved
cmd/log_drains.go Show resolved Hide resolved
cmd/log_drains.go Outdated Show resolved Hide resolved
log_drains/remove.go Outdated Show resolved Hide resolved
log_drains/remove.go Outdated Show resolved Hide resolved
log_drains/remove.go Show resolved Hide resolved
log_drains/remove.go Outdated Show resolved Hide resolved
@curzolapierre curzolapierre force-pushed the feature/576/remove_log_drains_from_db branch from 056fa27 to 5b082c8 Compare Jul 2, 2020
@curzolapierre curzolapierre requested a review from EtienneM Jul 2, 2020
@curzolapierre curzolapierre force-pushed the feature/576/remove_log_drains_from_db branch from 5b082c8 to 573cdb2 Compare Jul 2, 2020
Gopkg.toml Outdated Show resolved Hide resolved
@curzolapierre curzolapierre requested a review from EtienneM Jul 3, 2020
Copy link
Member

@EtienneM EtienneM left a comment

I just noticed but you forgot the CHANGELOG entry....

@curzolapierre curzolapierre requested a review from EtienneM Jul 3, 2020
@EtienneM EtienneM merged commit 3800a63 into master Jul 3, 2020
1 check passed
@EtienneM EtienneM deleted the feature/576/remove_log_drains_from_db branch Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants