Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle new queued deployment status #586

Merged
merged 2 commits into from Aug 19, 2020

Conversation

brandon-welsch
Copy link
Member

@brandon-welsch brandon-welsch commented Aug 18, 2020

Close #585

Merge then make a release of the CLI

@brandon-welsch brandon-welsch force-pushed the fix/585/handle-new-deployment-status branch from 880093f to 63a8545 Compare Aug 18, 2020
Copy link
Member

@johnsudaar johnsudaar left a comment

Could you also check the deploy with a similar output as Scalingo/deploy-gem#151 ?

@johnsudaar
Copy link
Member

johnsudaar commented Aug 19, 2020

When a deployment is queued:
2020-08-19_15-10

When a deployment is not queued:
2020-08-19_15-11

@brandon-welsch
Copy link
Member Author

brandon-welsch commented Aug 19, 2020

LGTM

@johnsudaar johnsudaar merged commit 1b5fc5e into master Aug 19, 2020
1 check passed
@EtienneM EtienneM deleted the fix/585/handle-new-deployment-status branch May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants