From 22f0d717ccdbcd30403a7312b6956a9bd11085e9 Mon Sep 17 00:00:00 2001 From: Ivan Kovalkovskyi Date: Thu, 12 Aug 2021 16:26:27 +0300 Subject: [PATCH] SCALRCORE-19437 display error from API while creating AP. --- README.md | 2 +- scalr/resource_scalr_access_policy.go | 2 +- scalr/resource_scalr_role.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 014a3c8d..a930c0d5 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ Extract the archive to get the provider binary. Follow the instructions on the [official documentation page](https://docs.scalr.com/en/latest/scalr-terraform-provider/index.html) to learn how to use it. ## Developing the provider ### Requirements -- [Terraform](https://www.terraform.io/downloads.html) >= 0.12.x +- [Terraform](https://www.terraform.io/downloads.html) >= 0.15.x - [Go](https://golang.org/doc/install) >= 1.13 - [jq](https://stedolan.github.io/jq/) >= 1.0 diff --git a/scalr/resource_scalr_access_policy.go b/scalr/resource_scalr_access_policy.go index cff8beaf..22422277 100644 --- a/scalr/resource_scalr_access_policy.go +++ b/scalr/resource_scalr_access_policy.go @@ -158,7 +158,7 @@ func resourceScalrAccessPolicyCreate(d *schema.ResourceData, meta interface{}) e ap, err := scalrClient.AccessPolicies.Create(ctx, options) if err != nil { return fmt.Errorf( - "Error creating access policy for %s %s on %s %s", subjectType, subjectId, scopeType, scopeId) + "Error creating access policy for %s %s on %s %s: %v", subjectType, subjectId, scopeType, scopeId, err) } d.SetId(ap.ID) return resourceScalrAccessPolicyRead(d, meta) diff --git a/scalr/resource_scalr_role.go b/scalr/resource_scalr_role.go index e14bd1af..15397218 100644 --- a/scalr/resource_scalr_role.go +++ b/scalr/resource_scalr_role.go @@ -95,7 +95,6 @@ func resourceScalrRoleRead(d *schema.ResourceData, meta interface{}) error { id := d.Id() log.Printf("[DEBUG] Read configuration of role: %s", id) role, err := scalrClient.Roles.Read(ctx, id) - log.Printf("[DEBUG] role permissions: %+v", role.Permissions) if err != nil { if err == scalr.ErrResourceNotFound { log.Printf("[DEBUG] Role %s not found", id) @@ -104,6 +103,7 @@ func resourceScalrRoleRead(d *schema.ResourceData, meta interface{}) error { } return fmt.Errorf("Error reading configuration of role %s: %v", id, err) } + log.Printf("[DEBUG] role permissions: %+v", role.Permissions) // Update the config. d.Set("name", role.Name)