Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Jan 14, 2011
  1. [z1245] Move ShapeshiftForm to SharedDefines.h and fix build for *nix.

    VladimirMangos committed
    (based on master commit 71fc253)
    (based on commit 32303bb)
  2. [z1244] Fixed not apply spell for current form at learning.

    VladimirMangos committed
    Some non-passive spells autocasted at shapeshift but without fix
    in case already active form at like spell learning it not has been casted
    in different from passive similar spells.
    This is fix apply dodge chance part of spell 17002 for described case.
    (based on master commit 1e5deec)
    (based on commit 25cc2de)
Commits on Jan 13, 2011
  1. @sidsukana

    [z1243] Fixed 23881 and ranks for 1.x spell data.

    sidsukana committed with VladimirMangos
    Signed-off-by: VladimirMangos <>
  2. @sidsukana

    [z1242] Fixed talent 11185 and ranks triggering for 1.x spell data.

    sidsukana committed with VladimirMangos
    Signed-off-by: VladimirMangos <>
  3. @sidsukana

    [z1241] Drop dead code for not existed in 1.x spell.

    sidsukana committed with VladimirMangos
    Signed-off-by: VladimirMangos <>
  4. [z1240] Implement 8 pieces effect of itemset 204.

    VladimirMangos committed
    (based on master commit 7e1a683)
    (based on commit 5af5aae)
  5. @sidsukana

    [z1239] Implement 50% chance for dispell from spell 23922 and ranks.

    sidsukana committed with VladimirMangos
    Signed-off-by: VladimirMangos <>
  6. [z1238] Implement magic detection as it work in 1.x

    BalakinUser committed with VladimirMangos
    Signed-off-by: VladimirMangos <>
  7. @sidsukana

    [z1237] Fixed spell 19977 and ranks code for 1.12.1

    sidsukana committed with VladimirMangos
    Signed-off-by: VladimirMangos <>
  8. @sidsukana

    [z1236] Apply debuff 25771 at spell 1022 and ranks buff apply

    sidsukana committed with VladimirMangos
    Signed-off-by: VladimirMangos <>
  9. @derex

    [z1235] Fixed crashes in ACE network code.

    derex committed with VladimirMangos
    Signed-off-by: VladimirMangos <>
    Thanks to kero99 for pointing to patch and testing.
    (based on master commit 07e9694)
    (based on commit d7c6778)
Commits on Jan 12, 2011
  1. @sidsukana

    [z1234] Fixed structure SMSG_SPELLDAMAGESHIELD to expected by 1.12.1

    sidsukana committed with VladimirMangos
    Signed-off-by: VladimirMangos <>
  2. [z1233] Apply spell mutiplier to final damage for health calculation …

    Quriq14 committed with VladimirMangos
    …in Spell::EffectHealthLeech.
    Signed-off-by: VladimirMangos <>
    (based on master commit ef6e30f)
    (based on commit 72ccefd)
  3. [z1232] Implement proper support spell auras with maxstack > 1 and ch…

    VladimirMangos committed
    …arges > 0.
    * Like auras expected to be proccessed in spell proc event code (not lost charge at use in spellmods code).
    * Move set max original aura stack cases to aura creating
    (based on master commit 4135b24)
    (based on master commit 01b46af)
    (based on master commit 31012f8)
    (based on commit 92fa983)
    In fact 1.12.1 not have like spells but drop support will be one compare less. After included in commit cleanups for old way.
  4. [z1231] Make players and totems always immune to taunt.

    VladimirMangos committed
    (based on master commit 59b36b7)
    (based on commit b4f712e)
  5. [z1230] Update coef to pre-3.x expected in `spell_bonus_data` for spe…

    Syn committed with VladimirMangos
    …ll 172
    Signed-off-by: VladimirMangos <>
    (based on master commit 1713d50)
    (based on commit 331d8fd)
  6. [z1229] BattleGround: call correct function at playerleave

    balrok committed with VladimirMangos
    it will now correctly drop the flag and correctly remove the player from
    eye of the storm objectives
    + also avoid the spamming of all "Player not found!" messages in battlegrounds
        maybe all existing "player not found!" places should now get an assert(false)
        since this shouldn't happen anymore
    + also better error output in GetBattleGroundQueueIdFromLevel
    (based on master commit c802cfb)
    (based on master commit 035b21f)
    (based on commit 6b46bb2)
  7. [z1228] Implement optional support post-3.1 and later fishing changes.

    VladimirMangos committed
    * Fishing now prowide junk loot at fail skill check.
      This can be enabled for post-3.1.x way work using SkillFail.Loot.Fishing option.
      Junk loot expected to be listed in fishing_loot_template entry 0.
    * Fishing can gain skill grow at skill fail check case.
      Controlled by SkillFail.Gain.Fishing option.
    * Fishing from fishing pool gameobject can't be fail.
      Controlled by SkillFail.Possible.FishingPool
    (based on master commit 902c3df)
    (based on master commit 74fe338)
    (based on master commit f43c272)
    (based on commit eda6635)
  8. [z1227] Prevent apply spell power bonuses to some item heals.

    przemratajczak committed with VladimirMangos
    Signed-off-by: VladimirMangos <>
    (based on master commit 2038573)
    Thanks to mns for find this important for backport commit.
    (based on commit 14a7428)
  9. [z1226] Implement reflect chance with telent 11189

    VladimirMangos committed
    In 1.x/2.x it work in diff. way from 3.x version
    Also fixed generic not expected limitation in pre-auraholder code
    for not calling aura boost code at remove for auras without visible slot.
    In aura holder version it already fixed but it too big problem for wait
    auraholder backporting.
    Signed-off-by: VladimirMangos <>
    (based on master commit a3d3fe4)
    (based on commit a15c62a)
    (based on commit 8961cbe)
    Reflection spell animation part not work in 1.x yet :/
  10. [z1225] Propertly note for not loaded script library version.

    VladimirMangos committed
    * Better support localization in case built-in version notes.
    * Move script library version functions to ScriptMgr
    (based on master commit 8076ef5)
    (based on commit 10700e7)
  11. [z1224] Proper sort spel 27681 in mangos.sql.

    VladimirMangos committed
    (based on master commit 9d98bec)
    (based on commit 05c5db2)
  12. [z1223] Some comments from not backportable commit.

    Splinter committed with VladimirMangos
    Signed-off-by: VladimirMangos <>
    (based on master commit 140f3f1)
    (based on commit ee572c8)
  13. [z1222] Sort Unit::HandleDummyAuraProc generic family spells in case.

    VladimirMangos committed
    (based on master commit 80ea28d)
    (based on commit 69de7eb)
  14. @triply

    [z1221] Next big step in BG code sync with master.

    triply committed with VladimirMangos
    Fixed possible crash in BGQueueRemoveEvent::Execute() when two paralell BattleGroundQueue Updates are called, optimalized code.
    Signed-off-by: Triply <>
    (based on master commit dc85df0)
    (based on commit 788b700)
    Cleanup BG code OnLoad calls.
    (based on master commit b01aa2b)
    (based on commit b0f90cc)
    Battleground queue related backports
    (based on master commit 4601ed3)
    (based on master commit 877e963)
    (based on master commit 6dd33ca)
    New attempt backport bg related commits. Please report stability porblems if its showup after this commit.
    (based on commit ab6cf26)
    Team related cleanups in generic code and battlegrounds code.
    Use BattleGround(AV)TeamIndex enum types in AV battleground code.
    * Added BattleGroundAVTeamIndex enum type for 3-case special team list fo AV.
    * Rename BattleGroundTeamId -> BattleGroundTeamIndex for clarify
    * Some safe checks added and dropped bogus call RewardReputationToTeam in BattleGroundAV::HandleQuestComplete
      for BattleGroundTeamIndex as faction. Unclear for what it expected used so dropped.
    Use Team enum types in all appropriate cases and catches bug in result fix.
    * Fixed memory lost and etc at not virtual EndBattleground call
    * Code cleanups.
    (based on master commit 83e7f13)
    (based on master commit 8fcfddf)
    (based on master commit 3faa764)
    (based on master commit 17693a6)
    (based on master commit 9373719)
    Thanks to mns for research code and help  for this and prev. backport commits.
    (based on commit 5317bbc)
  15. [z1220] More safe for use PET_FOLLOW_ANGLE define.

    VladimirMangos committed
    (based on master commit 9ccbdbf)
    (based on commit aae27fe)
  16. [z1219] Add peeking support to LockedQueue.

    XTZGZoReX committed with VladimirMangos
    Also make DB code thread-safe. Original patch by Machiavelli and Kero99.
    (based on master commit ea13ac3)
    (based on master commit 6bc7e97)
    (based on commit 9659f06)
    Signed-off-by: VladimirMangos <>
  17. [z1218] Alow implicit copy constrictor call for fix build at some com…

    VladimirMangos committed
    (based on master commit 4f8ebec)
    (based on commit ebb6c49)
  18. [z1218] Fixed spell 18790 unexpected spell power bonuses.

    mns committed with VladimirMangos
    Also fix server startup error for spell 12880
    by using data originally suggested by siduskana as more correct.
    Signed-off-by: VladimirMangos <>
    (based on commit 3d81a0b)
Commits on Jan 11, 2011
  1. [z1217] Implement mass mail send infrastructure.

    VladimirMangos committed
    It expected to be used in 2 case: some gameevent must send mails at start/end,
    and this can be useful in game commands. Both case wil implemented in later commits.
    * New MassMailMgr can accept tasks for send mass mails in safe way for map update threads context/etc.
    * It work in way:
       - By provided race mask or more generic SQL query string in async query selected affected characters
       - At query result ready at next world tick update in safe common part of tick code some from mails
         from queued mas mail tasks send.
       - Amount mails limited MassMailer.SendPerTick confir option (10 by default). This done for prevent
         high server load/lags at send too many mails in one tick (mail send all existed characters in DB
         who match to seelction criteria)
       - Server wait at shutdown complete mass mail tasks. This is now slowdown shutdown lot:
         with default setting 10K mail send in 20 secs (10000/50/10).
       - But manager not persistant for server crashes so any not send mails in queue lost at crash.
    * Implement mass mail gm commands.
      New comamnds mirror related normal sedn commands:
       - send mass items
       - send mass mail
       - send mass money
      Instead player name it expect or numeric racemask or textual race/team name or 'all'.
    * Implement game event mail sends at event start/stop.
      Also implement save game event state to DB mostly for avoid
      send mails at resume game event after server downtime.
    Thanks to X-Savior for inspiring and original research.
    (based on master commit f5c63c4)
    (based on master commit 534683c)
    (based on master commit 35028c6)
    (based on master commit e2e18ec)
    (based on master commit 84e29e0)
    (based on master commit dbc97cb)
    (based on master commit 96df816)
    (based on commit 9aea987)
  2. [z1216] Some cleanups in MailDraft API

    VladimirMangos committed
    * Use Set* names for cases when function replace old value by new (instead Add*)
    * Prevent hidden MailDraft copy create becase if draft have items (or body itemTextId) its can't be just shared
      and need preoprtly cloned, but item clone is high price operation (guid use, DB touched and etc)
      So this must be explictly operation. In next commits will be added clone function for this.
    * Some MailDraft overwrite by assign cases rewrited to more clean way.
    (based on master commit b5bd067)
    (based on commit 57638c9)
  3. @Ambal

    [z1215] Optimize memory usage of Field class used in DB code. Should …

    Ambal committed with VladimirMangos
    …also slightly speedup server startup time.
    Signed-off-by: Ambal <>
    (based on master commit 4b347cb)
    (based on commit 5a21ec6)
  4. [z1214] Config option for disable progress bar show at server startup.

    VladimirMangos committed
    Make happy nervouse ppl by some secs startup speedup.
    (based on master commit 5867cde)
    (based on master commit b74660e)
    (based on commit 18c25b2)
    (based on commit a9e419e)
  5. @Patman64

    [z1213] Add ghost speed rates in config: Death.Ghost.RunSpeed.*

    Patman64 committed with VladimirMangos
    Also clarify context for remove ghost auras place after set alive state.
    This let get more expected results at remove ghost speed aura.
    Signed-off-by: VladimirMangos <>
    (based on master commit 1fe6ac3)
    (based on master commit 4f1ca1d)
    (based on master commit c057c81)
    (based on commit c5802a5)
  6. [z1212] Report error about not existed item loot data only if item no…

    VladimirMangos committed
    …t have money loot.
    (based on commit master 06f6f62)
    (based on commit 9c35d44)
Something went wrong with that request. Please try again.