Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong type for Ansible "validate" #1256

Closed
GhostLyrics opened this issue Sep 23, 2020 · 0 comments · Fixed by #1776
Closed

Wrong type for Ansible "validate" #1256

GhostLyrics opened this issue Sep 23, 2020 · 0 comments · Fixed by #1776

Comments

@GhostLyrics
Copy link

Ansible template type has an attribute validate which is set to boolean in the JSON schema, but should be string. The copy one has the same validate type and should be checked and also corrected while working on this.

references:
@GerryFerdinandus GerryFerdinandus mentioned this issue Jul 31, 2021
Merged
madskristensen pushed a commit that referenced this issue Aug 2, 2021
@GerryFerdinandus
fix: [ansible] lineinfile.insertafter, lineinfile.insertbefore, pause…
a22542a 
….minutes and package.name (#1776)

* add: test module_lineifile.json

This does not pass the build

* fix: "insertafter" and "insertbefore"

Now also accept all string input

* add: test module_pause.json

This does not pass the build
This is a copy from the example page.

Also add "name": "..." or else it will not pass the build.
This is an other issue that need to be fix

* fix: pause "minutes" and "seconds"

It is now integer and not string as the example

note that the example also accept type "null"

* add: test module_package.json

This does not pass the build

* fix: package "name"

was only accepting string
It now accept both string + array

* empty commit

* add: test module_package.json

issue #509
Ansible schema doesn't handle lists passed to yum module

But it is all ready fix

* fix: module.template.validate must be type "string"

see issue #1256
Ansible template type has an attribute validate which is set to boolean in the JSON schema,
but should be string.

* add: test module_copy.json

issue #1256
Ansible template type has an attribute validate which is set to boolean
in the JSON schema, but should be string.
The copy one has the same validate type and should be checked
and also corrected while working on this.

But there is no "validate" proprety in the module.copy schema.
I do not know how this is posible. This schema ia auto gererated from the
documentation.

Add test module_copy.json to check if any this else is wrong.
The test module_copy.json does not detect this missing property
because there is no "additionalProperties": false for this "properties"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [ansible] lineinfile.insertafter, lineinfile.insertbefore, pause.minutes and package.name
1 participant
@GhostLyrics