Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema: Hugo #2138

Merged
merged 31 commits into from Mar 29, 2022
Merged

Add schema: Hugo #2138

merged 31 commits into from Mar 29, 2022

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Mar 16, 2022

  • non-object global properties
  • build property
  • caches property
  • cascade property
  • frontmatter property
  • imaging property
  • markup property
  • mediaTypes property
  • menus property
  • minify property
  • module property
  • outputFormats property
  • permalinks property
  • related property
  • security property
  • sitemap property
  • taxonomies property
  • prettify schema:
    • standardize all descriptions
    • add title property to all objects to make errors more descriptive

- describe all settings before and including "caches"
@EmilyGraceSeville7cf
Copy link
Contributor Author

EmilyGraceSeville7cf commented Mar 16, 2022

@GerryFerdinandus, what to do with Duplicate fileMatch found => config.json? Is it a critical error? Some tools can have similar named configs but as I know JSON schema could be chosen when such conflict occurs (in VS Code for instance).

EmilySeville7cfg added 2 commits March 16, 2022 17:43
- new props up to "enableMissingTranslationPlaceholders"
- placeholders for all remaining properties
src/schemas/json/hugo.json Outdated Show resolved Hide resolved
@GerryFerdinandus
Copy link
Contributor

@EmilySeville7cfg
AFAIK IDE, like visual studio and intelliJ, don't tell the user that they may have used the wrong schema.

Visual studio code tells me something is wrong. example using deploy.yml in github action does not work.
I still can't figure out how to disable the wrong conflicting schema.

remove the "fileMatch": []" to avoid conflict

@EmilyGraceSeville7cf EmilyGraceSeville7cf marked this pull request as ready for review March 25, 2022 13:30
@EmilyGraceSeville7cf EmilyGraceSeville7cf marked this pull request as draft March 25, 2022 13:32
EmilySeville7cfg added 3 commits March 26, 2022 16:19
- fix descriptions
- add more hints
- suggest front matter defaults for array items
@EmilyGraceSeville7cf
Copy link
Contributor Author

@GerryFerdinandus, please merge this PR. After it I'll move this schema to HUGO repo. 😄

@EmilyGraceSeville7cf
Copy link
Contributor Author

EmilyGraceSeville7cf commented Mar 26, 2022

remove the "fileMatch": []" to avoid conflict

My solution: add config.json to fileMatchConflict in src/schema-validation.json. We need to describe this file better (in .md).

@GerryFerdinandus
Copy link
Contributor

@EmilySeville7cfg
I can't merge additional name conflict/hijack. Maybe @madskristensen is willing to accept this merge.

@madskristensen
Copy link
Contributor

config.json is way too generic of a name. It will have way too many false file matches.

@EmilyGraceSeville7cf
Copy link
Contributor Author

As I understand schema link to config.json for Hugo site must be set-up in .vscode/settings.json before using. @madskristensen, you can merge this PR. 🚀

@madskristensen madskristensen merged commit cae44e6 into SchemaStore:master Mar 29, 2022
@madskristensen
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants