improve async client shutdown functionality #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanechternacht
previously approved these changes
Aug 25, 2025
bpapillon
reviewed
Aug 25, 2025
bpapillon
approved these changes
Aug 26, 2025
cbrady
deleted the
chris/sch-4288-fix-asyncschematicclient-shutdown-functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing issue where the shutdown signal hooks in the
AsyncSchematicClientwere not giving back control to the main process. This PR removes those hooks in favor of a dedicated shutdown function, this also provides support for async context manager methods_aenter_and_aexit_.