Upgraded project to gradle 5.1.1 and kotlin 1.3.11 #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranpons
changed the title
ferranpons
requested review from
CristianGM,
gerardpedreny,
marcserrascmspain and
sergiocastilloscmspain
gerardpedreny
approved these changes
Jan 21, 2019
CristianGM
reviewed
Jan 21, 2019
leku/build.gradle
Outdated
| @@ -139,7 +177,7 @@ bintray { | |||
| description = "Location picker component for Android. It returns a latitude,longitude and an address based on the location picked in the LocationPickerActivity provided." | |||
| publish = true | |||
| dryRun = false | |||
| override = true | |||
| override = false | |||
There was a problem hiding this comment.
Because we don't want to override an AAR already published.
This is what Docu says:
override = false //[Default: false] Whether to override version artifacts already published
There was a problem hiding this comment.
@CristianGM please check it out again. Thanks!
There was a problem hiding this comment.
Then it should have never been true.
It would be better to remove the line and keep it default.
There was a problem hiding this comment.
@CristianGM done! You're right it never should have been true but it was hard to make it work without testing these things.
CristianGM
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve one of the biggest issues of the recent versions. After ditching the old Novoda bintray plugin we had serious problems for uploading an AAR with all dependencies and sources. So I decided to upgrade gradle, all dependencies and add the sources to the publishing task. Hopefully this will solve the issue. 馃檹