Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update only if changed #18

Merged
merged 21 commits into from Oct 9, 2022
Merged

Update only if changed #18

merged 21 commits into from Oct 9, 2022

Conversation

Schneegans
Copy link
Owner

No description provided.

@Schneegans Schneegans merged commit bbc75b5 into master Oct 9, 2022
1 check passed
@Schneegans Schneegans deleted the feature/update-only-if-changed branch Oct 9, 2022
doRequest(getGistOptions, JSON.stringify({})).then(oldGist => {
if (oldGist.statusCode < 200 || oldGist.statusCode >= 400) {
// print the error, but don't fail the action.
console.log(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Schneegans because every run of action will go over this request, I think it should be changed from console.log to core.setFailed. In case the user will enter the wrong gistId, it should fail.
WDYT?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're right, it could fail early at this point. However, it will fail anyways when the action will later try to update the gist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants