New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does search / fuzzy search work? #2

Open
jack-guy opened this Issue May 10, 2018 · 10 comments

Comments

Projects
None yet
4 participants
@jack-guy

jack-guy commented May 10, 2018

Thanks for fixing #1 so quickly! I'm off and running with the extension, and in terms of speed the experience is already miles ahead of the SSHFS / Fuse solution I've been using.

Search / fuzzy search isn't working for me, however. I noticed there's a separate extension API for that in the FileSystemProvider - provideTextSearchResults. Has that been implemented yet? Would you need any help in doing so? Microsoft/vscode#45000 seems to have some good information.

@SchoofsKelvin

This comment has been minimized.

Owner

SchoofsKelvin commented May 10, 2018

The provideTextSearchResults seems to be part of the proposed API. It's already available to VSCode Insiders, and might be in 1.24.0, based off that issue and the May 2018 iteration plan.

I might actually start an insider branch and add this feature, for when they actually release it.

@jneuhaus20

This comment has been minimized.

jneuhaus20 commented Jun 8, 2018

Looks like it did make it into 1.24. And excited to try this extension out this weekend!

@SchoofsKelvin

This comment has been minimized.

Owner

SchoofsKelvin commented Jun 12, 2018

It's still a proposed API, which means it won't be actually released until (hopefully) 1.25

@jack-guy

This comment has been minimized.

jack-guy commented Jun 12, 2018

Are you looking for help with implementation @SchoofsKelvin? I might be able to chip in.

@SchoofsKelvin

This comment has been minimized.

Owner

SchoofsKelvin commented Jun 12, 2018

I've just copied the example from the Release Notes and am rewriting it now to work properly.

I regularly commit and push to the insider branch. Feel free to make any comments (or even commits) on it.

@lopugit

This comment has been minimized.

lopugit commented Sep 29, 2018

I would love to help with this too!!! :D can we implement this? does anyone know how? I get the error message "No search provider registered for scheme: ssh" from vscode

@SchoofsKelvin

This comment has been minimized.

Owner

SchoofsKelvin commented Sep 29, 2018

I've got a very simple working demo on the insiders branch, but it doesn't seem very efficient.

I'm thinking about using FileIndexProvider.provideFileIndex combined with the find command over SSH. This would force me to use an actual SSH connection, not just a (wrapped) SFTP connection. Currently it doesn't matter, but for later features, it could

Feel free to check out (and improve) the current implementation, or create your own. I won't be publishing it anyway until it moves from the proposed API into the actual API.

@lopugit

This comment has been minimized.

lopugit commented Sep 30, 2018

@SchoofsKelvin what do you mean by demo?

I'll sideload the insider build and try it out

@lopugit

This comment has been minimized.

lopugit commented Sep 30, 2018

you don't happen to develop on windows 10 do you? I'm actually resorting to running a windows 7 vm to connect to my osx smb share via vscode.... cause WinSshFs works to mount the filesystem but vscode crashes and causes windows explorer to crash too....... and vscode-sshfs, your beautiful program, doesn't have search, yet, maybe we can change that. But mainly windows 10 broke smb to osx so.... fml

@SchoofsKelvin

This comment has been minimized.

Owner

SchoofsKelvin commented Oct 3, 2018

I do use windows 10, but I never mount like that. I usually use the terminal, WinSCP and now my extension (although often I just use a git repository)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment