Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AutoDiffractor #29

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Add AutoDiffractor #29

merged 2 commits into from
Mar 11, 2024

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented Mar 11, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Fix #27

I asked the developer of Diffractor.jl and she said no specific fields or type parameters were needed in the struct

@Vaibhavdixit02 Vaibhavdixit02 merged commit 9f17b82 into main Mar 11, 2024
4 checks passed
@Vaibhavdixit02 Vaibhavdixit02 deleted the gd/diffractor branch March 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vaibhavdixit02 Vaibhavdixit02 Awaiting requested review from Vaibhavdixit02

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add AutoDiffractor
2 participants
@gdalle @Vaibhavdixit02