Skip to content

Conversation

@isaacsas
Copy link
Member

DiffEqBiological was using the exact parametric constructor form, which has now changed due to the addition of DEStats. This switches to using the more general form with kwargs.

@isaacsas
Copy link
Member Author

Except now syms have disappeared from legends again...

@ChrisRackauckas
Copy link
Member

@isaacsas
Copy link
Member Author

sir_model = @reaction_network SIR begin
           c1, s + i --> 2i
           c2, i --> r
       end c1 c2
df = DiscreteFunction(DiffEqBase.DISCRETE_INPLACE_DEFAULT,syms=sir_model.syms)

It's the DISCRETE_INPLACE_DEFAULT that messes it up. Using sir_model.f instead causes everything to work ok. Probably why I used the explicit parametric constructor before...

@isaacsas isaacsas merged commit 3d7b30f into SciML:master Feb 22, 2019
@isaacsas isaacsas deleted the discretefunction-fix branch February 22, 2019 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants