Fix indexing issues #175 and #174 #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrontsis
changed the title
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 73.56% 73.64% +0.07%
==========================================
Files 20 20
Lines 681 683 +2
==========================================
+ Hits 501 503 +2
Misses 180 180
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
Bump |
jonniedie
approved these changes
Feb 14, 2023
Collaborator
jonniedie
left a comment
jonniedie
left a comment
There was a problem hiding this comment.
Looks good. Thanks for these!
This was referenced Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the title, this PR fixes tow indexing issues (#175 and #174) and adds associated tests.
Note: When indexing with zero a zero length tuple or vector of symbols a vector instead of a componentvector is returned which I find inconsistent. I didn't opt to address this in this PR, as I that it is a result of more fundamental choices regarding
_getindexand the handling of ComponentVectors with flat axes only. I plan to open a separate issue to discuss these.