From a37842337e2712b1ad9ff38ddc0a00ce69a255a2 Mon Sep 17 00:00:00 2001 From: Jonnie Diegelman Date: Fri, 16 Jun 2023 21:30:22 -0400 Subject: [PATCH 1/5] Fix test for Cholesky factorization conversion --- test/runtests.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/runtests.jl b/test/runtests.jl index e334e65b..414d8e8f 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -619,7 +619,7 @@ end # Issue #100 chol = cholesky(cmat + I) - @test convert(Cholesky{Float32,Matrix{Float32}}, chol).factors isa Matrix{Float32} + @test convert(Cholesky{Float32}, chol).factors isa Matrix{Float32} # Issue #140 @test ComponentArrays.ArrayInterface.indices_do_not_alias(typeof(ca)) == true From e9e383de5241be5ea81fcdda9a5af890e4385e82 Mon Sep 17 00:00:00 2001 From: Jonnie Diegelman Date: Fri, 16 Jun 2023 21:32:19 -0400 Subject: [PATCH 2/5] Update Julia versions for tests --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7a8a04ca..bc6f9ca3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,7 @@ jobs: matrix: version: - '1.6' - - '1.7' + - '1.8' - '1' # Leave this line unchanged. '1' will automatically expand to the latest stable 1.x release of Julia. os: - ubuntu-latest From 291b508f7cafd750cc8bba3a52d3fe77e751fba7 Mon Sep 17 00:00:00 2001 From: Jonnie Diegelman Date: Fri, 16 Jun 2023 21:30:22 -0400 Subject: [PATCH 3/5] Fix test for Cholesky factorization conversion --- test/runtests.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/runtests.jl b/test/runtests.jl index e334e65b..414d8e8f 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -619,7 +619,7 @@ end # Issue #100 chol = cholesky(cmat + I) - @test convert(Cholesky{Float32,Matrix{Float32}}, chol).factors isa Matrix{Float32} + @test convert(Cholesky{Float32}, chol).factors isa Matrix{Float32} # Issue #140 @test ComponentArrays.ArrayInterface.indices_do_not_alias(typeof(ca)) == true From 2040934a8f3bdf2c35e8e6b7186de0b0ea7f6fb5 Mon Sep 17 00:00:00 2001 From: Jonnie Diegelman Date: Fri, 16 Jun 2023 21:32:19 -0400 Subject: [PATCH 4/5] Update Julia versions for tests --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7a8a04ca..bc6f9ca3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,7 @@ jobs: matrix: version: - '1.6' - - '1.7' + - '1.8' - '1' # Leave this line unchanged. '1' will automatically expand to the latest stable 1.x release of Julia. os: - ubuntu-latest From 67594357266254b1b4bb7e6e57d86356ff2baaad Mon Sep 17 00:00:00 2001 From: Jonnie Diegelman Date: Fri, 16 Jun 2023 21:52:12 -0400 Subject: [PATCH 5/5] Remove the cholesky test because its already converted --- test/runtests.jl | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/runtests.jl b/test/runtests.jl index 414d8e8f..4779ac1e 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -617,10 +617,6 @@ end @test typeof(zrv0) === typeof(rv0) @test typeof(zrv0.r[1]) == typeof(rv0[1]) - # Issue #100 - chol = cholesky(cmat + I) - @test convert(Cholesky{Float32}, chol).factors isa Matrix{Float32} - # Issue #140 @test ComponentArrays.ArrayInterface.indices_do_not_alias(typeof(ca)) == true @test ComponentArrays.ArrayInterface.instances_do_not_alias(typeof(ca)) == false