fix: restructure of tracked component arrays #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/fix_tracker
branch
from
afe8bc2 to
7a46897
Compare
Member
Author
|
locally verified that this patch fixes our downstream issues |
Member
Author
|
cc @jonniedie for a review |
Member
Author
|
@jonniedie bump on this |
jonniedie
approved these changes
Sep 10, 2024
Collaborator
jonniedie
left a comment
jonniedie
left a comment
There was a problem hiding this comment.
Thanks for this! Sorry to get to it so late.
Member
|
I do have to wonder if it could be helpful to move this to SciML or JuliaArrays. You've been responsive so it hasn't turned into an issue, but it does kind of worry me that this has become a pretty crucial piece of the infrastructure but remains one of the only single maintainer packages. The first page of the PR history there is mostly Avik, Vedant, Lilith, Aayush, and Dhariya putting in PRs for SciML maintenance, so it does look like it has entered this phase of continued maintenance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still need to test if this fixes the scimlsensitivity issues.
cc @ChrisRackauckas