Skip to content

Respect broadcasting of functions that changes the eltype #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Respect broadcasting of functions that changes the eltype #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/broadcasting.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,7 @@ end
# of respecting Union eltypes than the default method in Base.
function Base.Broadcast.broadcasted(f, x::ComponentArray)
data = getdata(x)
new_data = similar(data)
@inbounds for i in eachindex(data)
new_data[i] = f(data[i])
end
new_data = map(f, x)
return ComponentArray(new_data, getaxes(x))
end

Expand Down Expand Up @@ -116,4 +113,4 @@ function fill_flat(Ax::VarAxes, N)
axs = (axs..., ntuple(x -> FlatAxis(), N-n)...)
end
return axs
end
end