[WIP] DMDc #10
Merged
[WIP] DMDc #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/dmdc.jl
Outdated
| @@ -0,0 +1,72 @@ | |||
| using DifferentialEquations | |||
Member
There was a problem hiding this comment.
use OrdinaryDiffEq directly for these
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 76.51% 79.27% +2.75%
==========================================
Files 5 6 +1
Lines 132 193 +61
==========================================
+ Hits 101 153 +52
- Misses 31 40 +9
Continue to review full report at Codecov.
|
|
|
||
| # See fail with unknown input | ||
| sys = DMDc(X, U) | ||
| # But with a little more knowledge |
Member
|
Did you pull that example from the paper? That's a good one to keep in mind as a positive proof that added knowledge can be required for equation discovery. |
Collaborator
Author
|
From the book of Kutz and Proctor. But it is also in the paper and on their homepage as a Matlab block I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs tests and maybe callback integration